Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1068203002: histograms.xml: Streaming histogram update. (Closed)

Created:
5 years, 8 months ago by marja
Modified:
5 years, 8 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

histograms.xml: Streaming histogram update. We now stream deferred and parsing blocking scripts too, so some obsolete histograms are no longer obsolete. Added new histograms. R=isherman@chromium.org BUG= Committed: https://crrev.com/d1f5e1f8b3a7f04a3f31dbb1728a84d9facf1d94 Cr-Commit-Position: refs/heads/master@{#324402}

Patch Set 1 #

Total comments: 2

Patch Set 2 : units -> enum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
marja
isherman, ptal
5 years, 8 months ago (2015-04-08 09:38:28 UTC) #1
Ilya Sherman
LGTM assuming "units" is just a typo for "enum". Otherwise, I'd like to better understand ...
5 years, 8 months ago (2015-04-08 18:26:23 UTC) #2
marja
Oops, it was actually wrong already in the histogram where I copied it from. The ...
5 years, 8 months ago (2015-04-09 08:05:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068203002/20001
5 years, 8 months ago (2015-04-09 08:05:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 09:22:12 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 09:23:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1f5e1f8b3a7f04a3f31dbb1728a84d9facf1d94
Cr-Commit-Position: refs/heads/master@{#324402}

Powered by Google App Engine
This is Rietveld 408576698