Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 10682: Inverted character classes (Closed)

Created:
12 years, 1 month ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

- Moved node class declarations into .h file where they belong. - Implemented adding of inverted character classes to dispatch tables. - Cleaned sorting up a bit and fixed a windows build problem.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -239 lines) Patch
M src/globals.h View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.h View 3 chunks +208 lines, -15 lines 0 comments Download
M src/jsregexp.cc View 4 chunks +37 lines, -195 lines 2 comments Download
M src/list.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/list-inl.h View 2 chunks +7 lines, -4 lines 0 comments Download
M src/utils.h View 2 chunks +29 lines, -0 lines 2 comments Download
M test/cctest/test-regexp.cc View 3 chunks +25 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Christian Plesner Hansen
12 years, 1 month ago (2008-11-13 10:27:20 UTC) #1
Erik Corry
LGTM http://codereview.chromium.org/10682/diff/1/3 File src/jsregexp.cc (right): http://codereview.chromium.org/10682/diff/1/3#newcode1545 Line 1545: table->AddRange(CharacterRange(last, 0xFFFF), index); I think this goes ...
12 years, 1 month ago (2008-11-13 11:45:42 UTC) #2
Christian Plesner Hansen
12 years, 1 month ago (2008-11-13 11:58:36 UTC) #3
http://codereview.chromium.org/10682/diff/1/3
File src/jsregexp.cc (right):

http://codereview.chromium.org/10682/diff/1/3#newcode1545
Line 1545: table->AddRange(CharacterRange(last, 0xFFFF), index);
Good point.  I've fixed it and added a test.

http://codereview.chromium.org/10682/diff/1/7
File src/utils.h (right):

http://codereview.chromium.org/10682/diff/1/7#newcode87
Line 87: static int Spaceship(const T& a, const T& b) {
http://en.wikipedia.org/wiki/Spaceship_operator

We can make a custom comparator function if it turns out to be a performance
issue.

Powered by Google App Engine
This is Rietveld 408576698