Handle layer clients in LayoutSVGResourceContainer::registerResource

Source/core/layout/svg/LayoutSVGResourceContainer.cpp

Index: Source/core/layout/svg/LayoutSVGResourceContainer.cpp
diff --git a/Source/core/layout/svg/LayoutSVGResourceContainer.cpp b/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
index 49f9c02bc841d1c3b2d773d35c81165cbe7e0d74..1343647f54d1b5d33a0edfb2581f22a4f691b41d 100644
--- a/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
+++ b/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
@@ -223,6 +223,11 @@ void LayoutSVGResourceContainer::registerResource()
         if (!layoutObject)
             continue;
 
+        // If the client is has a layer (is a non-SVGElement) we need to signal

[kouhei (in TOK), 2015/04/08 17:14:41]

s/is has/has/

[fs, 2015/04/08 17:26:04]

Done.

+        // invalidation in the same way as is done in markAllClientLayersForInvalidation above.
+        if (layoutObject->hasLayer() && resourceType() == FilterResourceType)
+            toLayoutBoxModelObject(layoutObject)->layer()->filterNeedsPaintInvalidation();

[kouhei (in TOK), 2015/04/08 17:14:41]

Would it make sense to do a early "continue" here, instead of removing the
assert on SVGResourcesCache?

[fs, 2015/04/08 17:26:04]

I believe we still want to do the setNeedsLayoutAndFullPaintInvalidation, so
something like:

if (layoutObject->hasLayer() &&...) {
    ...filterNeedsPaintInval
     idation();
} else {
   ...
   ...clientStyleChanged();
}
layoutObject->setNeeds...

might work I suppose. I wouldn't think it's fundamentally wrong to call
clientStyleChanged with a non-SVG element though.

[kouhei (in TOK), 2015/04/08 17:28:50]

Thanks for the explanation. No strong opinion here. lgtm either way.

[fs, 2015/04/08 17:34:16]

Hmm, it's quite possible that the "filter update hack" will be enough though (it
triggers a style-recalc IIRC.)

[fs, 2015/04/09 10:21:33]

Ended up doing like this suggests, because I concluded that it should be enough
(and is more consistent with the rest of the code.)

+
         StyleDifference diff;
         diff.setNeedsFullLayout();
         SVGResourcesCache::clientStyleChanged(layoutObject, diff, layoutObject->styleRef());