browser_tests for searching within Downloads in Files

browser_tests for searching within Downloads in Files

This adds tests for a search in Downloads. It first performs a basic search,
it then checks that the search is case-insensitive and performs a search that
should match no files and checks the correct error string is displayed.

TEST=browser_tests --gtest_filter="*FileDisplay/FileManagerBrowserTest/{4,5,6}*"
BUG=None

Committed: https://crrev.com/8b73ec308a874c1986723b6e5ae1c33a74618d9e
Cr-Commit-Position: refs/heads/master@{#324384}

[dhaddock1, 2015-04-07 22:23:16]

dhaddock@chromium.org changed reviewers:
+ fukino@chromium.org, mtomasz@chromium.org

[mtomasz, 2015-04-08 00:20:30]

lgtm with nit

https://codereview.chromium.org/1067983002/diff/20001/ui/file_manager/integra...
File ui/file_manager/integration_tests/file_manager/file_display.js (right):

https://codereview.chromium.org/1067983002/diff/20001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:97: * @param
Array<Object> expectedResults The results set.
nit: {Array<Object>}

[dhaddock1, 2015-04-08 01:00:57]

The CQ bit was checked by dhaddock@chromium.org

[dhaddock1, 2015-04-08 01:00:58]

The CQ bit was unchecked by dhaddock@chromium.org

[dhaddock1, 2015-04-08 01:06:28]

https://codereview.chromium.org/1067983002/diff/20001/ui/file_manager/integra...
File ui/file_manager/integration_tests/file_manager/file_display.js (right):

https://codereview.chromium.org/1067983002/diff/20001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:97: * @param
Array<Object> expectedResults The results set.
On 2015/04/08 00:20:30, mtomasz wrote:
> nit: {Array<Object>}

Done.

[dhaddock1, 2015-04-08 01:06:57]

The CQ bit was checked by dhaddock@chromium.org

[dhaddock1, 2015-04-08 01:06:57]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/1067983002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-04-08 01:07:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1067983002/40001

[commit-bot: I haz the power, 2015-04-08 03:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-08 03:59:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fukino, 2015-04-08 06:35:51]

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
File ui/file_manager/integration_tests/file_manager/file_display.js (right):

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:145:
searchDownloads('hello', [ENTRIES.hello])
nit: Put ';' at the end of line.

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:149:
searchDownloads('HELLO', [ENTRIES.hello])
nit: ditto

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:190:
remoteCall.waitForElement(appId, ['#no-search-results']).then(this.next);
The element '#no-search-results' always exists in the DOM tree, so this line
doesn't wait anything.

To wait the message is shown, how about waiting ['#no-search-result b'] and
check assertEq(elements.text, searchTerm) in the next step?

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:192:
function(elements) {
nit: elements -> element?

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:194:
elements.text);
nit: 4 spaces indent.

[dhaddock1, 2015-04-08 21:18:00]

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
File ui/file_manager/integration_tests/file_manager/file_display.js (right):

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:145:
searchDownloads('hello', [ENTRIES.hello])
On 2015/04/08 06:35:51, fukino wrote:
> nit: Put ';' at the end of line.

Done.

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:149:
searchDownloads('HELLO', [ENTRIES.hello])
On 2015/04/08 06:35:51, fukino wrote:
> nit: ditto

Done.

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:190:
remoteCall.waitForElement(appId, ['#no-search-results']).then(this.next);
On 2015/04/08 06:35:51, fukino wrote:
> The element '#no-search-results' always exists in the DOM tree, so this line
> doesn't wait anything.
> 
> To wait the message is shown, how about waiting ['#no-search-result b'] and
> check assertEq(elements.text, searchTerm) in the next step?

Done.

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:192:
function(elements) {
On 2015/04/08 06:35:51, fukino wrote:
> nit: elements -> element?

Done.

https://codereview.chromium.org/1067983002/diff/40001/ui/file_manager/integra...
ui/file_manager/integration_tests/file_manager/file_display.js:194:
elements.text);
On 2015/04/08 06:35:51, fukino wrote:
> nit: 4 spaces indent.

Done. Changed above so it doesn't wrap

[fukino, 2015-04-09 03:29:56]

lgtm. Thanks!

[dhaddock1, 2015-04-09 04:32:30]

The CQ bit was checked by dhaddock@chromium.org

[dhaddock1, 2015-04-09 04:32:30]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/1067983002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-04-09 04:32:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1067983002/60001

[commit-bot: I haz the power, 2015-04-09 06:16:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-09 06:17:19]

Patchset 4 (id:??) landed as
https://crrev.com/8b73ec308a874c1986723b6e5ae1c33a74618d9e
Cr-Commit-Position: refs/heads/master@{#324384}