Fix an unused variable in NSPR

Fix an unused variable in NSPR

See https://bugzilla.mozilla.org/show_bug.cgi?id=1126408

BUG=none
R=rsleevi@chromium.org, wtc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=294785

[davidben, 2015-04-10 17:31:02]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[davidben, 2015-04-10 17:31:03]

I believe the error is:
third_party\nss\nspr\pr\src\io\prfdcach.c(216) : warning C4101: 'pop' :
unreferenced local variable

May as well send that upstream.

[wtc, 2015-04-10 18:26:12]

On 2015/04/10 17:31:03, David Benjamin wrote:
> I believe the error is:
> third_party\nss\nspr\pr\src\io\prfdcach.c(216) : warning C4101: 'pop' :
> unreferenced local variable
> 
> May as well send that upstream.

The latest revision of prfdcache.c doesn't have "pop". I found that this was
fixed in January:
https://bugzilla.mozilla.org/show_bug.cgi?id=1126408

[davidben, 2015-04-10 18:28:51]

On 2015/04/10 18:26:12, wtc wrote:
> On 2015/04/10 17:31:03, David Benjamin wrote:
> > I believe the error is:
> > third_party\nss\nspr\pr\src\io\prfdcach.c(216) : warning C4101: 'pop' :
> > unreferenced local variable
> > 
> > May as well send that upstream.
> 
> The latest revision of prfdcache.c doesn't have "pop". I found that this was
> fixed in January:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1126408

Cool. I'm putting together some BoringSSL code (they don't need a whole lot...
just some PKCS #7 stuff) for the one consumer that needed this, so we may not
need to bother with the suppression, but may as well do this in parallel.

[wtc, 2015-04-10 22:22:05]

wtc@chromium.org changed reviewers:
+ wtc@chromium.org

[wtc, 2015-04-10 22:22:06]

Patch set 1 LGTM. I would fix the compiler warning with a local patch, but
suppressing the warning is fine.

https://codereview.chromium.org/1067933003/diff/1/nss.gyp
File nss.gyp (right):

https://codereview.chromium.org/1067933003/diff/1/nss.gyp#newcode248
nss.gyp:248: # TODO(davidben): suppress C4101 in prfdcach.c.

Please add the NSPR bug number
(https://bugzilla.mozilla.org/show_bug.cgi?id=1126408) and a note that this
suppression can be removed for NSPR 4.10.9 or later.

[davidben, 2015-04-13 18:47:53]

https://codereview.chromium.org/1067933003/diff/1/nss.gyp
File nss.gyp (right):

https://codereview.chromium.org/1067933003/diff/1/nss.gyp#newcode248
nss.gyp:248: # TODO(davidben): suppress C4101 in prfdcach.c.
On 2015/04/10 22:22:06, wtc wrote:
> 
> Please add the NSPR bug number
> (https://bugzilla.mozilla.org/show_bug.cgi?id=1126408) and a note that this
> suppression can be removed for NSPR 4.10.9 or later.

Done.

[davidben, 2015-04-13 19:04:56]

Switched to a local patch instead.

[Ryan Sleevi, 2015-04-13 19:09:20]

LGTM (and uprev DEPS)

[davidben, 2015-04-13 19:12:49]

Committed patchset #4 (id:60001) manually as 294785 (presubmit successful).

[wtc, 2015-04-14 02:31:34]

https://codereview.chromium.org/1067933003/diff/60001/README.chromium
File README.chromium (right):

https://codereview.chromium.org/1067933003/diff/60001/README.chromium#newcode39
README.chromium:39: - patches/nspr-remove-io.patch: Remove IO operations in NSPR
to allow NSS

NSPR patches are described in this section. Since this patch is expected to be
removed soon, it may not be worth the trouble fixing this.

[davidben, 2015-04-21 20:31:33]

https://codereview.chromium.org/1067933003/diff/60001/README.chromium
File README.chromium (right):

https://codereview.chromium.org/1067933003/diff/60001/README.chromium#newcode39
README.chromium:39: - patches/nspr-remove-io.patch: Remove IO operations in NSPR
to allow NSS
On 2015/04/14 02:31:34, wtc wrote:
> 
> NSPR patches are described in this section. Since this patch is expected to be
> removed soon, it may not be worth the trouble fixing this.

Whoops, I didn't notice that. I'll go upload a CL to fix it since it'll be
pretty quick.