Issue 1067933002: Use NumberIsNaN in collections.js and make it inlined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1067933002: Use NumberIsNaN in collections.js and make it inlined (Closed)

Created:
5 years, 8 months ago by adamk

Modified:
5 years, 8 months ago

Reviewers:
arv (Not doing code reviews)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Use NumberIsNaN in collections.js and make it inlined Committed: https://crrev.com/a0dbe25bceeb27ff9ab315d2bade4359aaf7230c Cr-Commit-Position: refs/heads/master@{#27641}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/collection.js	View		4 chunks	+4 lines, -4 lines	0 comments	Download
	M	src/v8natives.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

adamk

This takes care of one of your comments on the original patch. Going to make ...

5 years, 8 months ago (2015-04-07 19:08:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067933002/1

5 years, 8 months ago (2015-04-07 19:31:07 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-07 19:52:34 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a0dbe25bceeb27ff9ab315d2bade4359aaf7230c
Cr-Commit-Position: refs/heads/master@{#27641}