Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1067903004: Simplify collections.js now that it's wrapped in an IIFE (Closed)

Created:
5 years, 8 months ago by adamk
Modified:
5 years, 8 months ago
CC:
v8-dev, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify collections.js now that it's wrapped in an IIFE Also wrap templates.js in an IIFE to avoid unnecessary pollution of the builtins object. Committed: https://crrev.com/f089e5c8467047a1571ecbbfc5556a7e619c6b1d Cr-Commit-Position: refs/heads/master@{#27638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -61 lines) Patch
M src/collection.js View 3 chunks +35 lines, -57 lines 0 comments Download
M src/templates.js View 5 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 8 months ago (2015-04-07 18:39:00 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 8 months ago (2015-04-07 18:41:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067903004/1
5 years, 8 months ago (2015-04-07 18:42:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 19:00:41 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 19:00:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f089e5c8467047a1571ecbbfc5556a7e619c6b1d
Cr-Commit-Position: refs/heads/master@{#27638}

Powered by Google App Engine
This is Rietveld 408576698