Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: chrome/browser/net/proxy_service_factory.cc

Issue 1067903003: Re-disable V8-based proxy resolving with the --single-process command line is set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/proxy_service_factory.cc
diff --git a/chrome/browser/net/proxy_service_factory.cc b/chrome/browser/net/proxy_service_factory.cc
index 1674a60a044fa2ffe75f85077875ed70da4748fb..a50e520d3dfa0fe808b7457c0a478ea66c408f37 100644
--- a/chrome/browser/net/proxy_service_factory.cc
+++ b/chrome/browser/net/proxy_service_factory.cc
@@ -104,6 +104,13 @@ net::ProxyService* ProxyServiceFactory::CreateProxyService(
bool use_v8 = false;
#else
bool use_v8 = !command_line.HasSwitch(switches::kWinHttpProxyResolver);
+ // TODO(eroman): Figure out why this doesn't work in single-process mode.
+ // Should be possible now that a private isolate is used.
+ // http://crbug.com/474654
+ if (use_v8 && command_line.HasSwitch(switches::kSingleProcess)) {
+ LOG(ERROR) << "Cannot use V8 Proxy resolver in single process mode.";
+ use_v8 = false; // Fallback to non-v8 implementation.
+ }
#endif // defined(OS_IOS)
size_t num_pac_threads = 0u; // Use default number of threads.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698