Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 1067903003: Re-disable V8-based proxy resolving with the --single-process command line is set. (Closed)

Created:
5 years, 8 months ago by eroman
Modified:
5 years, 8 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-disable V8-based proxy resolving with the --single-process command line is set. BUG=474654 Committed: https://crrev.com/4a0e1d8374b6b0a400aa1b8965b21452bec3b1a4 Cr-Commit-Position: refs/heads/master@{#324087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/net/proxy_service_factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eroman
5 years, 8 months ago (2015-04-07 18:14:05 UTC) #2
mmenke
LGTM
5 years, 8 months ago (2015-04-07 18:55:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067903003/1
5 years, 8 months ago (2015-04-07 19:09:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 19:14:22 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 19:15:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a0e1d8374b6b0a400aa1b8965b21452bec3b1a4
Cr-Commit-Position: refs/heads/master@{#324087}

Powered by Google App Engine
This is Rietveld 408576698