SkCanvas::resetForNextPicture()

SkCanvas::resetForNextPicture()

No diffs against head for DM --config 8888 gpu 2ndpic-8888 2ndpic-gpu.

  picture_overhead_draw	1.62us ->  1.6us	0.99x
picture_overhead_nodraw	 792ns ->  342ns	0.43x

tiles and serialization modes will also test this a bit.

BUG=chromium:470553
Committed: https://skia.googlesource.com/skia/+/f920e468ac66a36c9653d1b11181480295044c7d

Committed: https://skia.googlesource.com/skia/+/feaadee1c38e1d4e1ec0069a3509ef6fbc5fbeff

[mtklein, 2015-04-07 18:27:58]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-07 18:28:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1067893002/20001

[commit-bot: I haz the power, 2015-04-07 18:36:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 18:36:08]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[mtklein, 2015-04-07 20:47:14]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-07 20:47:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1067893002/40001

[commit-bot: I haz the power, 2015-04-07 20:57:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 20:57:26]

This issue passed the CQ dry run.

[reed1, 2015-04-07 21:02:12]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-04-07 21:02:13]

lgtm w/ style-nit

https://codereview.chromium.org/1067893002/diff/40001/src/core/SkRecorder.cpp
File src/core/SkRecorder.cpp (right):

https://codereview.chromium.org/1067893002/diff/40001/src/core/SkRecorder.cpp...
src/core/SkRecorder.cpp:45: SkCanvas::resetForNextPicture(bounds.roundOut());
this->resetForNextPicture()
or
this->INHERITED::resetForNextPicture()

the current form seems out of place with our other sites when calling into the
baseclass for a method (non-static).

[mtklein, 2015-04-07 21:02:49]

mtklein@google.com changed reviewers:
- reed@google.com

[mtklein, 2015-04-07 21:04:42]

https://codereview.chromium.org/1067893002/diff/40001/src/core/SkRecorder.cpp
File src/core/SkRecorder.cpp (right):

https://codereview.chromium.org/1067893002/diff/40001/src/core/SkRecorder.cpp...
src/core/SkRecorder.cpp:45: SkCanvas::resetForNextPicture(bounds.roundOut());
On 2015/04/07 21:02:13, reed1 wrote:
> this->resetForNextPicture()
> or
> this->INHERITED::resetForNextPicture()
> 
> the current form seems out of place with our other sites when calling into the
> baseclass for a method (non-static).

Done.  Brain fart.  No need to mention SkCanvas...

[mtklein, 2015-04-07 21:04:45]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-04-07 21:04:46]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1067893002/#ps60001
(title: "this->")

[commit-bot: I haz the power, 2015-04-07 21:05:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1067893002/60001

[mtklein, 2015-04-07 21:05:55]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2015-04-07 21:05:58]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-04-07 21:06:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1067893002/60001

[commit-bot: I haz the power, 2015-04-07 21:11:26]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f920e468ac66a36c9653d1b11181480295044c7d

[mtklein, 2015-04-07 22:26:52]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1062353002/ by mtklein@google.com.

The reason for reverting is:
https://uberchromegw.corp.google.com/i/client.skia/builders/Linux%20Tests/bui....

[mtklein, 2015-04-08 18:05:04]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-04-08 18:05:04]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1067893002/#ps80001
(title: "Return null when we're not recording.  Should fix printing failures.")

[commit-bot: I haz the power, 2015-04-08 18:05:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1067893002/80001

[mtklein, 2015-04-08 18:08:06]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2015-04-08 18:08:08]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-04-08 18:08:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1067893002/80001

[commit-bot: I haz the power, 2015-04-08 18:25:52]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/feaadee1c38e1d4e1ec0069a3509ef6fbc5fbeff