Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 1067863007: [test] Limit "unittests" suite to default variant. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Limit "unittests" suite to default variant. This changes the unittests suite to be run in only the default variant, because unit tests are (and should be) written to be independent from global flags. R=machenbach@chromium.org Committed: https://crrev.com/e81ee90018283555f811719f6ae0091f6198c526 Cr-Commit-Position: refs/heads/master@{#28054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/testrunner/local/testsuite.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
PTAL. This reduces runtime of the "unittests" suite from ~50sec to ~15sec on my machine. ...
5 years, 8 months ago (2015-04-24 12:01:46 UTC) #1
Michael Achenbach
lgtm. On the bots we pass an explicit --no-variants to the test driver for executing ...
5 years, 8 months ago (2015-04-24 21:42:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067863007/1
5 years, 8 months ago (2015-04-27 07:58:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 08:20:25 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 08:20:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e81ee90018283555f811719f6ae0091f6198c526
Cr-Commit-Position: refs/heads/master@{#28054}

Powered by Google App Engine
This is Rietveld 408576698