Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1067853005: [Android] Update more GN paths related to testing/android/ move. (Closed)

Created:
5 years, 8 months ago by kjellander_chromium
Modified:
5 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Update more GN paths related to testing/android/ move. https://codereview.chromium.org/1079963002/ fixed one path, but there were two more that needs fixing. TESTED=Locally passing build using: gn gen out/Default --args="target_os=\"android\" target_cpu=\"arm\"" ninja -C out/Default test_opus_padding Committed: https://crrev.com/8af41b356f3d3f97b7cbde771b039a0a46bff0de Cr-Commit-Position: refs/heads/master@{#324854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/pylib/gtest/test_package_apk.py View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kjellander_chromium
Sorry for the need of a second CL to fix this. I didn't test things ...
5 years, 8 months ago (2015-04-13 11:42:32 UTC) #2
jbudorick
build/android/ lgtm
5 years, 8 months ago (2015-04-13 12:58:16 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-13 12:59:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067853005/1
5 years, 8 months ago (2015-04-13 13:02:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 15:50:12 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 15:51:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8af41b356f3d3f97b7cbde771b039a0a46bff0de
Cr-Commit-Position: refs/heads/master@{#324854}

Powered by Google App Engine
This is Rietveld 408576698