[Android] Move power implementation from device_utils to battery_utils

[Android] Move implementation of battery utils from device utils

Move the implementation of doing power related actions from device_utils to battery_utils.

BUG=472763
Committed: https://crrev.com/01041e84d9d798ec651240a5ff941e453e02bfe9
Cr-Commit-Position: refs/heads/master@{#324094}

[rnephew (Reviews Here), 2015-04-07 16:24:42]

rnephew@chromium.org changed reviewers:
+ jbudorick@chromium.org, klundberg@chromium.org, perezju@chromium.org

[rnephew (Reviews Here), 2015-04-07 16:24:43]

https://codereview.chromium.org/1067853003/diff/1/build/android/pylib/device/...
File build/android/pylib/device/battery_utils.py (right):

https://codereview.chromium.org/1067853003/diff/1/build/android/pylib/device/...
build/android/pylib/device/battery_utils.py:242: ['dumpsys', 'battery', 'set',
'usb', '1'], check_return=True)
Want to point this part out, since I don't want it to look like I'm sneaking
this in. I added this line to make sure that charging is enabled before clearing
power data. It has to be enabled to clear data or it might fail the check below.

[jbudorick, 2015-04-07 16:56:34]

You need to rephrase your commit message.

I know you only moved these implementations, but I'm going to suggest (minor)
changes anyway.

https://codereview.chromium.org/1067853003/diff/20001/build/android/pylib/dev...
File build/android/pylib/device/battery_utils.py (right):

https://codereview.chromium.org/1067853003/diff/20001/build/android/pylib/dev...
build/android/pylib/device/battery_utils.py:169: logging.warning('Unknown line
found in dumpsys battery.')
nit: combine these two logging lines

  logging.warning('Unknown line found in dumpsys battery: "%s"', line)

https://codereview.chromium.org/1067853003/diff/20001/build/android/pylib/dev...
build/android/pylib/device/battery_utils.py:172: k, v = line.split(': ', 1)
Why line.split(': ') when you're checking for ':' in line above?

[rnephew (Reviews Here), 2015-04-07 17:06:14]

https://codereview.chromium.org/1067853003/diff/20001/build/android/pylib/dev...
File build/android/pylib/device/battery_utils.py (right):

https://codereview.chromium.org/1067853003/diff/20001/build/android/pylib/dev...
build/android/pylib/device/battery_utils.py:169: logging.warning('Unknown line
found in dumpsys battery.')
On 2015/04/07 16:56:33, jbudorick wrote:
> nit: combine these two logging lines
> 
>   logging.warning('Unknown line found in dumpsys battery: "%s"', line)

Done.

https://codereview.chromium.org/1067853003/diff/20001/build/android/pylib/dev...
build/android/pylib/device/battery_utils.py:172: k, v = line.split(': ', 1)
On 2015/04/07 16:56:33, jbudorick wrote:
> Why line.split(': ') when you're checking for ':' in line above?

Done.

[jbudorick, 2015-04-07 18:50:48]

lgtm

[rnephew (Reviews Here), 2015-04-07 18:57:56]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2015-04-07 18:58:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1067853003/40001

[commit-bot: I haz the power, 2015-04-07 19:54:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-07 19:55:22]

Patchset 3 (id:??) landed as
https://crrev.com/01041e84d9d798ec651240a5ff941e453e02bfe9
Cr-Commit-Position: refs/heads/master@{#324094}