Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 1067853002: Adding draw looper gm for textblobs (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@scrolling
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Adding draw looper gm for textblobs BUG=skia: Committed: https://skia.googlesource.com/skia/+/d0b5c33fda86a5fe91007b7875a28e8fa8ff70c8

Patch Set 1 #

Patch Set 2 : pare down #

Patch Set 3 : rebase #

Patch Set 4 : remove comment #

Total comments: 3

Patch Set 5 : rebase #

Patch Set 6 : cleanup #

Patch Set 7 : is this right? #

Patch Set 8 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -0 lines) Patch
A gm/textbloblooper.cpp View 1 2 3 4 5 6 7 1 chunk +257 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
joshualitt
New GM to test draw loopers + text blobs
5 years, 8 months ago (2015-04-07 15:39:19 UTC) #3
bsalomon
lgtm w/ nits https://codereview.chromium.org/1067853002/diff/60001/gm/textbloblooper.cpp File gm/textbloblooper.cpp (right): https://codereview.chromium.org/1067853002/diff/60001/gm/textbloblooper.cpp#newcode2 gm/textbloblooper.cpp:2: * Copyright 2013 Google Inc. 2015 ...
5 years, 8 months ago (2015-04-08 15:34:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067853002/100001
5 years, 8 months ago (2015-04-09 18:24:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/437)
5 years, 8 months ago (2015-04-09 18:37:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067853002/140001
5 years, 8 months ago (2015-04-10 13:10:00 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 13:17:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/d0b5c33fda86a5fe91007b7875a28e8fa8ff70c8

Powered by Google App Engine
This is Rietveld 408576698