Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1067843002: Add API to sync_driver::SyncService for iOS (Closed)

Created:
5 years, 8 months ago by droger
Modified:
5 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add API to sync_driver::SyncService for iOS This CL moves several methods from ProfileSyncService to sync_driver::SyncService so that they can be called on iOS. Committed: https://crrev.com/d8f8dc8f620e8b02e1ad8c3b9b88c262af0188c5 Cr-Commit-Position: refs/heads/master@{#324211}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -105 lines) Patch
M chrome/browser/sync/profile_sync_service.h View 1 16 chunks +23 lines, -103 lines 0 comments Download
M components/sync_driver/sync_service.h View 1 2 2 chunks +116 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
droger
5 years, 8 months ago (2015-04-07 15:51:13 UTC) #2
Nicolas Zea
LGTM with a request https://codereview.chromium.org/1067843002/diff/20001/components/sync_driver/sync_service.h File components/sync_driver/sync_service.h (right): https://codereview.chromium.org/1067843002/diff/20001/components/sync_driver/sync_service.h#newcode54 components/sync_driver/sync_service.h:54: virtual bool IsSyncEnabledAndLoggedIn() = 0; ...
5 years, 8 months ago (2015-04-07 16:57:31 UTC) #3
droger
Thanks for the review, done.
5 years, 8 months ago (2015-04-08 07:38:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067843002/40001
5 years, 8 months ago (2015-04-08 07:39:33 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-08 11:10:21 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 11:11:25 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d8f8dc8f620e8b02e1ad8c3b9b88c262af0188c5
Cr-Commit-Position: refs/heads/master@{#324211}

Powered by Google App Engine
This is Rietveld 408576698