Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1067823002: content/renderer/media: Update the include path to i420_video_frame.h (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, magjed_webrtc, pbos-webrtc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content/renderer/media: Update the include path to i420_video_frame.h Clients should now include webrtc/video_frame.h which is the right header for I420VideoFrame type, i420_video_frame.h is just a pass through header include. This should help fix pbos' TODO in the WebRTC repo and allow us to land https://webrtc-codereview.appspot.com/46819004/. BUG=None R=tommi@chromium.org Committed: https://crrev.com/025c6ccc7f3e0996ef5efc0c8a7660bb1e4c32be Cr-Commit-Position: refs/heads/master@{#324334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
tfarina
5 years, 8 months ago (2015-04-07 15:13:29 UTC) #1
pbos
lgtm, but I don't know if you have owners', tommi is OOO this week.
5 years, 8 months ago (2015-04-08 13:39:34 UTC) #3
tfarina
Dale, could you approve this?
5 years, 8 months ago (2015-04-08 13:54:35 UTC) #5
DaleCurtis
lgtm
5 years, 8 months ago (2015-04-08 21:49:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067823002/1
5 years, 8 months ago (2015-04-08 22:12:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 01:36:14 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 01:37:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/025c6ccc7f3e0996ef5efc0c8a7660bb1e4c32be
Cr-Commit-Position: refs/heads/master@{#324334}

Powered by Google App Engine
This is Rietveld 408576698