Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1067793002: [release-tools] Fix v8rel in branch period. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[release-tools] Fix v8rel in branch period. In case the v8 revision in chromium was set to an older revision that's not in the list of recent v8 releases, the script will bail out too early. This changes iterates over 10 more revisions, which should cover all exceeding revisions in branch period. NOTRY=true TBR=hablich@chromium.org Committed: https://crrev.com/b9871d6f373346c641d5f57fbff06cd85004e31b Cr-Commit-Position: refs/heads/master@{#27622}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M tools/release/releases.py View 4 chunks +18 lines, -2 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1067793002/diff/1/tools/release/releases.py File tools/release/releases.py (right): https://codereview.chromium.org/1067793002/diff/1/tools/release/releases.py#newcode404 tools/release/releases.py:404: # TODO(machenbach): Unify common code with method above. ...
5 years, 8 months ago (2015-04-07 09:39:30 UTC) #2
tandrii(chromium)
lgtm
5 years, 8 months ago (2015-04-07 10:50:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067793002/1
5 years, 8 months ago (2015-04-07 11:12:16 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-07 11:12:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067793002/1
5 years, 8 months ago (2015-04-07 11:28:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 11:28:24 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 11:28:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9871d6f373346c641d5f57fbff06cd85004e31b
Cr-Commit-Position: refs/heads/master@{#27622}

Powered by Google App Engine
This is Rietveld 408576698