Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1067773002: Re-enable ICOImageDecoderTest.Decoding. (Closed)

Created:
5 years, 8 months ago by Peter Kasting
Modified:
5 years, 8 months ago
Reviewers:
Noel Gordon, piman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable ICOImageDecoderTest.Decoding. BUG=371290 TBR=piman Committed: https://crrev.com/13930475895316e34f8b51ca81f9df647f3448ae Cr-Commit-Position: refs/heads/master@{#324025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/renderer/ico_image_decoder_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Peter Kasting
Now that the md5sums for the tests have been updated, I think this should Just ...
5 years, 8 months ago (2015-04-07 03:01:25 UTC) #2
Noel Gordon
LGTM
5 years, 8 months ago (2015-04-07 03:30:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067773002/1
5 years, 8 months ago (2015-04-07 08:35:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54469)
5 years, 8 months ago (2015-04-07 08:44:37 UTC) #7
Peter Kasting
+piman for OWNERS TBR
5 years, 8 months ago (2015-04-07 08:57:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067773002/1
5 years, 8 months ago (2015-04-07 08:57:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 09:00:55 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/13930475895316e34f8b51ca81f9df647f3448ae Cr-Commit-Position: refs/heads/master@{#324025}
5 years, 8 months ago (2015-04-07 09:01:50 UTC) #13
piman
5 years, 8 months ago (2015-04-07 16:23:50 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698