bindings: Use Maybe version of Get in bindings/

Source/bindings/core/v8/ScriptValueSerializer.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "bindings/core/v8/ScriptValueSerializer.h"
 
 #include "bindings/core/v8/V8ArrayBuffer.h"
 #include "bindings/core/v8/V8ArrayBufferView.h"
 #include "bindings/core/v8/V8Blob.h"
@@ skipping 478 matching lines @@
 
 int SerializedScriptValueWriter::v8StringWriteOptions()
 {
     return v8::String::NO_NULL_TERMINATION;
 }
 
 ScriptValueSerializer::StateBase* ScriptValueSerializer::AbstractObjectState::serializeProperties(bool ignoreIndexed, ScriptValueSerializer& serializer)
 {
     while (m_index < m_propertyNames->Length()) {
         if (!m_nameDone) {
-            v8::Local<v8::Value> propertyName = m_propertyNames->Get(m_index);
-            if (StateBase* newState = serializer.checkException(this))
-                return newState;
-            if (propertyName.IsEmpty())
-                return serializer.handleError(InputError, "Empty property names cannot be cloned.", this);
+            v8::Local<v8::Value> propertyName;
+            if (!m_propertyNames->Get(serializer.context(), m_index).ToLocal(&propertyName))
+                return serializer.handleError(JSException, "", this);

[Yuki, 2015/04/07 07:37:57]

Can we add any descriptions for the error?

[bashi, 2015/04/07 08:47:01]

Done.

             bool hasStringProperty = propertyName->IsString() && v8CallBoolean(composite()->HasRealNamedProperty(serializer.context(), propertyName.As<v8::String>()));
             if (StateBase* newState = serializer.checkException(this))
                 return newState;
             bool hasIndexedProperty = !hasStringProperty && propertyName->IsUint32() && v8CallBoolean(composite()->HasRealIndexedProperty(serializer.context(), propertyName->Uint32Value()));
             if (StateBase* newState = serializer.checkException(this))
                 return newState;
             if (hasStringProperty || (hasIndexedProperty && !ignoreIndexed)) {
                 m_propertyName = propertyName;
             } else {
                 ++m_index;
                 continue;
             }
         }
         ASSERT(!m_propertyName.IsEmpty());
         if (!m_nameDone) {
             m_nameDone = true;
             if (StateBase* newState = serializer.doSerialize(m_propertyName, this))
                 return newState;
         }
-        v8::Local<v8::Value> value = composite()->Get(m_propertyName);
-        if (StateBase* newState = serializer.checkException(this))
-            return newState;
+        v8::Local<v8::Value> value;
+        if (!composite()->Get(serializer.context(), m_propertyName).ToLocal(&value))
+            return serializer.handleError(JSException, "", this);

[Yuki, 2015/04/07 07:37:57]

Can we add any descriptions for the error?

[bashi, 2015/04/07 08:47:01]

Done.

         m_nameDone = false;
         m_propertyName.Clear();
         ++m_index;
         ++m_numSerializedProperties;
         // If we return early here, it's either because we have pushed a new state onto the
         // serialization state stack or because we have encountered an error (and in both cases
         // we are unwinding the native stack).
         if (StateBase* newState = serializer.doSerialize(value, this))
             return newState;
     }
@@ skipping 10 matching lines @@
 }
 
 ScriptValueSerializer::StateBase* ScriptValueSerializer::ObjectState::objectDone(unsigned numProperties, ScriptValueSerializer& serializer)
 {
     return serializer.writeObject(numProperties, this);
 }
 
 ScriptValueSerializer::StateBase* ScriptValueSerializer::DenseArrayState::advance(ScriptValueSerializer& serializer)
 {
     while (m_arrayIndex < m_arrayLength) {
-        v8::Local<v8::Value> value = composite().As<v8::Array>()->Get(m_arrayIndex);
+        v8::Local<v8::Value> value;
+        if (!composite().As<v8::Array>()->Get(serializer.context(), m_arrayIndex).ToLocal(&value))
+            return serializer.handleError(JSException, "", this);

[Yuki, 2015/04/07 07:37:57]

Can we add any descriptions for the error?

[bashi, 2015/04/07 08:47:01]

Done.

         m_arrayIndex++;
         if (StateBase* newState = serializer.checkException(this))
             return newState;
         if (StateBase* newState = serializer.doSerialize(value, this))
             return newState;
     }
     return serializeProperties(true, serializer);
 }
 
 ScriptValueSerializer::StateBase* ScriptValueSerializer::DenseArrayState::objectDone(unsigned numProperties, ScriptValueSerializer& serializer)
@@ skipping 1357 matching lines @@
         return false;
     uint32_t objectReference = m_openCompositeReferenceStack[m_openCompositeReferenceStack.size() - 1];
     m_openCompositeReferenceStack.shrink(m_openCompositeReferenceStack.size() - 1);
     if (objectReference >= m_objectPool.size())
         return false;
     *object = m_objectPool[objectReference];
     return true;
 }
 
 } // namespace blink