Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Side by Side Diff: Source/bindings/core/v8/ArrayValue.cpp

Issue 1067763002: bindings: Use Maybe version of Get in bindings/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 bool ArrayValue::get(size_t index, Dictionary& value) const 55 bool ArrayValue::get(size_t index, Dictionary& value) const
56 { 56 {
57 if (isUndefinedOrNull()) 57 if (isUndefinedOrNull())
58 return false; 58 return false;
59 59
60 if (index >= m_array->Length()) 60 if (index >= m_array->Length())
61 return false; 61 return false;
62 62
63 ASSERT(m_isolate); 63 ASSERT(m_isolate);
64 ASSERT(m_isolate == v8::Isolate::GetCurrent()); 64 ASSERT(m_isolate == v8::Isolate::GetCurrent());
65 v8::Local<v8::Value> indexedValue = m_array->Get(v8::Integer::NewFromUnsigne d(m_isolate, index)); 65 v8::Local<v8::Value> indexedValue;
66 if (indexedValue.IsEmpty() || !indexedValue->IsObject()) 66 if (!m_array->Get(m_isolate->GetCurrentContext(), index).ToLocal(&indexedVal ue) || !indexedValue->IsObject())
67 return false; 67 return false;
68 68
69 value = Dictionary(indexedValue, m_isolate, m_exceptionState); 69 value = Dictionary(indexedValue, m_isolate, m_exceptionState);
70 return true; 70 return true;
71 } 71 }
72 72
73 } // namespace blink 73 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/core/v8/NPV8Object.cpp » ('j') | Source/bindings/core/v8/NPV8Object.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698