Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1067743002: Add a more detailed flag description for the enable-npapi lab. (Closed)

Created:
5 years, 8 months ago by Will Harris
Modified:
5 years, 8 months ago
Reviewers:
laforge, jschuh, laforge
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a more detailed flag description for the enable-npapi lab. BUG=409094, 295137 Committed: https://crrev.com/59718776e0da6fcf2d323e579fec6aeee9ced14c Cr-Commit-Position: refs/heads/master@{#323996}

Patch Set 1 #

Total comments: 2

Patch Set 2 : words #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Will Harris
nits on the grammar appreciated :)
5 years, 8 months ago (2015-04-06 23:14:28 UTC) #2
laforge
Suggestion for alt wording. https://codereview.chromium.org/1067743002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1067743002/diff/1/chrome/app/generated_resources.grd#newcode5900 chrome/app/generated_resources.grd:5900: + Enables the use of ...
5 years, 8 months ago (2015-04-07 00:03:29 UTC) #3
laforge
https://codereview.chromium.org/1067743002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1067743002/diff/1/chrome/app/generated_resources.grd#newcode5900 chrome/app/generated_resources.grd:5900: + Enables the use of NPAPI plugins. This flag ...
5 years, 8 months ago (2015-04-07 00:12:55 UTC) #5
jschuh
On 2015/04/07 00:12:55, laforge wrote: > https://codereview.chromium.org/1067743002/diff/1/chrome/app/generated_resources.grd > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/1067743002/diff/1/chrome/app/generated_resources.grd#newcode5900 > ...
5 years, 8 months ago (2015-04-07 00:24:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067743002/20001
5 years, 8 months ago (2015-04-07 00:25:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 01:14:58 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 01:16:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59718776e0da6fcf2d323e579fec6aeee9ced14c
Cr-Commit-Position: refs/heads/master@{#323996}

Powered by Google App Engine
This is Rietveld 408576698