content/browser/bootstrap_sandbox_mac.cc - Issue 1067733006: Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/bootstrap_sandbox_mac.cc

Issue 1067733006: Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mac compile fix Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_child_process_watcher.cc ('K') | « components/crash/browser/crash_dump_manager_android.cc ('k') | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/bootstrap_sandbox_mac.cc

diff --git a/content/browser/bootstrap_sandbox_mac.cc b/content/browser/bootstrap_sandbox_mac.cc

index 2361563b1972647ea422e7350856d14a9e5e7035..c4662ada4f48b2bb01735e9db116e68a5fb0b236 100644

--- a/content/browser/bootstrap_sandbox_mac.cc

+++ b/content/browser/bootstrap_sandbox_mac.cc

@@ -31,7 +31,9 @@ class BootstrapSandboxPolicy : public BrowserChildProcessObserver {

// BrowserChildProcessObserver:

void BrowserChildProcessHostDisconnected(

const ChildProcessData& data) override;

- void BrowserChildProcessCrashed(const ChildProcessData& data) override;

+ void BrowserChildProcessCrashed(

+ const ChildProcessData& data,

+ int exit_code) override;

private:

friend struct DefaultSingletonTraits<BootstrapSandboxPolicy>;

@@ -53,7 +55,8 @@ void BootstrapSandboxPolicy::BrowserChildProcessHostDisconnected(

}

void BootstrapSandboxPolicy::BrowserChildProcessCrashed(

- const ChildProcessData& data) {

+ const ChildProcessData& data,

+ int exit_code) {

sandbox()->ChildDied(data.handle);

}