Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 1067733006: Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.h ('k') | chrome/browser/chrome_child_process_watcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index f41e589a8314e3742e2ae2d19b3b9c0d9d57fba4..863c96a8c4e25b5ebef6c627001b884590d47815 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -27,6 +27,7 @@
#include "base/time/default_tick_clock.h"
#include "base/trace_event/trace_event.h"
#include "chrome/browser/chrome_browser_main.h"
+#include "chrome/browser/chrome_child_process_watcher.h"
#include "chrome/browser/chrome_content_browser_client.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/component_updater/chrome_component_updater_configurator.h"
@@ -273,6 +274,8 @@ void BrowserProcessImpl::StartTearDown() {
// the IO thread.
promo_resource_service_.reset();
+ child_process_watcher_.reset();
+
#if !defined(OS_ANDROID)
// Debugger must be cleaned up before IO thread and NotificationService.
remote_debugging_server_.reset();
@@ -1061,6 +1064,8 @@ void BrowserProcessImpl::PreMainMessageLoopRun() {
storage_monitor::StorageMonitor::Create();
#endif
+ child_process_watcher_.reset(new ChromeChildProcessWatcher());
+
platform_part_->PreMainMessageLoopRun();
}
« no previous file with comments | « chrome/browser/browser_process_impl.h ('k') | chrome/browser/chrome_child_process_watcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698