Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: components/crash/browser/crash_dump_manager_android.h

Issue 1067733006: Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_ 5 #ifndef COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
6 #define COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_ 6 #define COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/files/file.h" 10 #include "base/files/file.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 private: 48 private:
49 typedef std::map<int, base::FilePath> ChildProcessIDToMinidumpPath; 49 typedef std::map<int, base::FilePath> ChildProcessIDToMinidumpPath;
50 50
51 static void ProcessMinidump(const base::FilePath& minidump_path, 51 static void ProcessMinidump(const base::FilePath& minidump_path,
52 base::ProcessHandle pid); 52 base::ProcessHandle pid);
53 53
54 // content::BrowserChildProcessObserver implementation: 54 // content::BrowserChildProcessObserver implementation:
55 void BrowserChildProcessHostDisconnected( 55 void BrowserChildProcessHostDisconnected(
56 const content::ChildProcessData& data) override; 56 const content::ChildProcessData& data) override;
57 void BrowserChildProcessCrashed( 57 void BrowserChildProcessCrashed(
58 const content::ChildProcessData& data) override; 58 const content::ChildProcessData& data,
59 int exit_code) override;
59 60
60 // NotificationObserver implementation: 61 // NotificationObserver implementation:
61 void Observe(int type, 62 void Observe(int type,
62 const content::NotificationSource& source, 63 const content::NotificationSource& source,
63 const content::NotificationDetails& details) override; 64 const content::NotificationDetails& details) override;
64 65
65 // Called on child process exit (including crash). 66 // Called on child process exit (including crash).
66 void OnChildExit(int child_process_id, base::ProcessHandle pid); 67 void OnChildExit(int child_process_id, base::ProcessHandle pid);
67 68
68 content::NotificationRegistrar notification_registrar_; 69 content::NotificationRegistrar notification_registrar_;
69 70
70 // This map should only be accessed with its lock aquired as it is accessed 71 // This map should only be accessed with its lock aquired as it is accessed
71 // from the PROCESS_LAUNCHER and UI threads. 72 // from the PROCESS_LAUNCHER and UI threads.
72 base::Lock child_process_id_to_minidump_path_lock_; 73 base::Lock child_process_id_to_minidump_path_lock_;
73 ChildProcessIDToMinidumpPath child_process_id_to_minidump_path_; 74 ChildProcessIDToMinidumpPath child_process_id_to_minidump_path_;
74 75
75 base::FilePath crash_dump_dir_; 76 base::FilePath crash_dump_dir_;
76 77
77 static CrashDumpManager* instance_; 78 static CrashDumpManager* instance_;
78 79
79 DISALLOW_COPY_AND_ASSIGN(CrashDumpManager); 80 DISALLOW_COPY_AND_ASSIGN(CrashDumpManager);
80 }; 81 };
81 82
82 } // namespace breakpad 83 } // namespace breakpad
83 84
84 #endif // COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_ 85 #endif // COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
OLDNEW
« no previous file with comments | « chromecast/browser/metrics/cast_stability_metrics_provider.cc ('k') | components/crash/browser/crash_dump_manager_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698