Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chromecast/browser/metrics/cast_stability_metrics_provider.h

Issue 1067733006: Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMECAST_BROWSER_METRICS_CAST_STABILITY_METRICS_PROVIDER_H_ 5 #ifndef CHROMECAST_BROWSER_METRICS_CAST_STABILITY_METRICS_PROVIDER_H_
6 #define CHROMECAST_BROWSER_METRICS_CAST_STABILITY_METRICS_PROVIDER_H_ 6 #define CHROMECAST_BROWSER_METRICS_CAST_STABILITY_METRICS_PROVIDER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/process/kill.h" 9 #include "base/process/kill.h"
10 #include "components/metrics/metrics_provider.h" 10 #include "components/metrics/metrics_provider.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 void LogExternalCrash(const std::string& crash_type); 50 void LogExternalCrash(const std::string& crash_type);
51 51
52 private: 52 private:
53 // content::NotificationObserver implementation: 53 // content::NotificationObserver implementation:
54 void Observe(int type, 54 void Observe(int type,
55 const content::NotificationSource& source, 55 const content::NotificationSource& source,
56 const content::NotificationDetails& details) override; 56 const content::NotificationDetails& details) override;
57 57
58 // content::BrowserChildProcessObserver implementation: 58 // content::BrowserChildProcessObserver implementation:
59 void BrowserChildProcessCrashed( 59 void BrowserChildProcessCrashed(
60 const content::ChildProcessData& data) override; 60 const content::ChildProcessData& data,
61 int exit_code) override;
61 62
62 // Records a renderer process crash. 63 // Records a renderer process crash.
63 void LogRendererCrash(content::RenderProcessHost* host, 64 void LogRendererCrash(content::RenderProcessHost* host,
64 base::TerminationStatus status, 65 base::TerminationStatus status,
65 int exit_code); 66 int exit_code);
66 67
67 // Records a renderer process hang. 68 // Records a renderer process hang.
68 void LogRendererHang(); 69 void LogRendererHang();
69 70
70 // Registrar for receiving stability-related notifications. 71 // Registrar for receiving stability-related notifications.
71 content::NotificationRegistrar registrar_; 72 content::NotificationRegistrar registrar_;
72 73
73 // Reference to the current MetricsService. Raw pointer is safe, since 74 // Reference to the current MetricsService. Raw pointer is safe, since
74 // MetricsService is responsible for the lifetime of 75 // MetricsService is responsible for the lifetime of
75 // CastStabilityMetricsProvider. 76 // CastStabilityMetricsProvider.
76 ::metrics::MetricsService* metrics_service_; 77 ::metrics::MetricsService* metrics_service_;
77 78
78 DISALLOW_COPY_AND_ASSIGN(CastStabilityMetricsProvider); 79 DISALLOW_COPY_AND_ASSIGN(CastStabilityMetricsProvider);
79 }; 80 };
80 81
81 } // namespace metrics 82 } // namespace metrics
82 } // namespace chromecast 83 } // namespace chromecast
83 84
84 #endif // CHROMECAST_BROWSER_METRICS_CAST_STABILITY_METRICS_PROVIDER_H_ 85 #endif // CHROMECAST_BROWSER_METRICS_CAST_STABILITY_METRICS_PROVIDER_H_
OLDNEW
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chromecast/browser/metrics/cast_stability_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698