Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1067723002: Whitelist CNNIC certs (Closed)

Created:
5 years, 8 months ago by Ryan Sleevi
Modified:
5 years, 8 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist CNNIC certs BUG=473408 TBR=davidben Committed: https://crrev.com/ad0863803901e6c477f976de0e6218b154fee6d5 Cr-Commit-Position: refs/heads/master@{#324119}

Patch Set 1 #

Patch Set 2 : Remove certs with invalid subject encodings #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5889 lines, -5 lines) Patch
M net/cert/cert_verify_proc_whitelist.cc View 1 1 chunk +5889 lines, -5 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
Ryan Sleevi
David: This is based on the CNNIC whitelist. I'm now cross-referencing with the CT databases ...
5 years, 8 months ago (2015-04-06 23:22:46 UTC) #2
davidben
https://codereview.chromium.org/1067723002/diff/20001/net/cert/cert_verify_proc_whitelist.cc File net/cert/cert_verify_proc_whitelist.cc (right): https://codereview.chromium.org/1067723002/diff/20001/net/cert/cert_verify_proc_whitelist.cc#newcode1461 net/cert/cert_verify_proc_whitelist.cc:1461: { 0x44, 0xe5, 0x20, 0x99, 0x22, 0x26, 0x8a, 0x4b, ...
5 years, 8 months ago (2015-04-07 00:06:55 UTC) #3
Ryan Sleevi
Landing TBR; leaving the expired one in because it's close enough to the date window ...
5 years, 8 months ago (2015-04-07 19:33:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067723002/20001
5 years, 8 months ago (2015-04-07 19:33:39 UTC) #6
davidben
lgtm. Verified that my tool independently gives the same results for both leafs and roots ...
5 years, 8 months ago (2015-04-07 19:52:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 21:09:29 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 21:10:15 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad0863803901e6c477f976de0e6218b154fee6d5
Cr-Commit-Position: refs/heads/master@{#324119}

Powered by Google App Engine
This is Rietveld 408576698