Clean up enhanced_bookmark_utils.h/cc

Clean up enhanced_bookmark_utils.h/cc

Remove unused constant and dead code in these files.

BUG=473606
Committed: https://crrev.com/009136427e548a66384ad698430b880083c6b67e
Cr-Commit-Position: refs/heads/master@{#324049}

[qiankun, 2015-04-07 11:29:12]

qiankun.miao@intel.com changed reviewers:
+ noyau@chromium.org, thestig@chromium.org

[qiankun, 2015-04-07 11:29:12]

PTAL.

[noyau (Ping after 24h), 2015-04-07 11:38:09]

noyau@chromium.org changed reviewers:
+ lpromero@chromium.org

[noyau (Ping after 24h), 2015-04-07 11:38:09]

Louis, can you check that we don't use this constant in iOS? Thanks.

[lpromero, 2015-04-07 11:41:24]

On 2015/04/07 11:38:09, noyau wrote:
> Louis, can you check that we don't use this constant in iOS? Thanks.

We use it inlined in bookmark_splay_utils_ios.mm:
UMA_HISTOGRAM_ENUMERATION("Stars.LaunchLocation", launchLocation,
So LGTM for the clean up in the component.

[lpromero, 2015-04-07 11:41:26]

On 2015/04/07 11:38:09, noyau wrote:
> Louis, can you check that we don't use this constant in iOS? Thanks.

We use it inlined in bookmark_splay_utils_ios.mm:
UMA_HISTOGRAM_ENUMERATION("Stars.LaunchLocation", launchLocation,
So LGTM for the clean up in the component.

[noyau (Ping after 24h), 2015-04-07 13:38:01]

On 2015/04/07 11:41:26, lpromero wrote:
> On 2015/04/07 11:38:09, noyau wrote:
> > Louis, can you check that we don't use this constant in iOS? Thanks.
> 
> We use it inlined in bookmark_splay_utils_ios.mm:
> UMA_HISTOGRAM_ENUMERATION("Stars.LaunchLocation", launchLocation,
> So LGTM for the clean up in the component.

Thanks. lgtm

[qiankun, 2015-04-07 13:46:21]

The CQ bit was checked by qiankun.miao@intel.com

[commit-bot: I haz the power, 2015-04-07 13:46:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1067703004/1

[commit-bot: I haz the power, 2015-04-07 15:58:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-07 15:59:43]

Patchset 1 (id:??) landed as
https://crrev.com/009136427e548a66384ad698430b880083c6b67e
Cr-Commit-Position: refs/heads/master@{#324049}

[Lei Zhang, 2015-04-07 21:59:29]

https://codereview.chromium.org/1067703004/diff/1/components/enhanced_bookmar...
File components/enhanced_bookmarks/enhanced_bookmark_utils.cc (right):

https://codereview.chromium.org/1067703004/diff/1/components/enhanced_bookmar...
components/enhanced_bookmarks/enhanced_bookmark_utils.cc:16: class
BookmarkNameComparator : public std::binary_function<const BookmarkNode*,
Now BookmarkNameComparator is dead code. Care to do a follow up CL? You can
remove #include "base/i18n/string_compare.h" as well.