Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 106763012: Code cleanup: Removing redundant function calls from loadPendingImage(). (Closed)

Created:
6 years, 11 months ago by arpitab_
Modified:
6 years, 11 months ago
Reviewers:
eseidel
CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Code cleanup: Removing redundant function calls from loadPendingImage(). Also using Image::nullImage() directly instead of through RenderImageResource::nullImage(). Removing extra header file includes from RenderImageResource.h Merged from Darin's WebKit patch: trac.webkit.org/changeset/160478 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164392

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing lint errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M Source/core/css/resolver/StyleResourceLoader.cpp View 1 1 chunk +6 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderImageResource.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderImageResource.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
arpitab_
6 years, 11 months ago (2013-12-30 12:35:13 UTC) #1
eseidel
lgtm https://codereview.chromium.org/106763012/diff/1/Source/core/rendering/RenderImageResource.h File Source/core/rendering/RenderImageResource.h (right): https://codereview.chromium.org/106763012/diff/1/Source/core/rendering/RenderImageResource.h#newcode56 Source/core/rendering/RenderImageResource.h:56: virtual PassRefPtr<Image> image(int /* width */ = 0, ...
6 years, 11 months ago (2013-12-30 17:14:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/106763012/1
6 years, 11 months ago (2013-12-30 17:14:51 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=17604
6 years, 11 months ago (2013-12-30 18:45:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/106763012/180001
6 years, 11 months ago (2013-12-31 07:05:37 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2013-12-31 08:23:03 UTC) #6
Message was sent while issue was closed.
Change committed as 164392

Powered by Google App Engine
This is Rietveld 408576698