Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: third_party/libaddressinput/chromium/cpp/test/rule_test.cc

Issue 106763007: [rac] Parse postal code formats and required fields in libaddressinput. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile on windows. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (C) 2013 Google Inc. 1 // Copyright (C) 2013 Google Inc.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "rule.h" 15 #include "rule.h"
16 16
17 #include <libaddressinput/address_field.h> 17 #include <libaddressinput/address_field.h>
18 18
19 #include <string> 19 #include <string>
20 #include <utility> 20 #include <utility>
21 #include <vector> 21 #include <vector>
22 22
23 #include <gtest/gtest.h> 23 #include <gtest/gtest.h>
24 24
25 #include "address_field_util.h"
26 #include "messages.h" 25 #include "messages.h"
27 #include "region_data_constants.h" 26 #include "region_data_constants.h"
28 27
29 namespace { 28 namespace {
30 29
31 using i18n::addressinput::AddressField; 30 using i18n::addressinput::AddressField;
32 using i18n::addressinput::ADMIN_AREA; 31 using i18n::addressinput::ADMIN_AREA;
32 using i18n::addressinput::COUNTRY;
33 using i18n::addressinput::LOCALITY; 33 using i18n::addressinput::LOCALITY;
34 using i18n::addressinput::NEWLINE;
35 using i18n::addressinput::ORGANIZATION; 34 using i18n::addressinput::ORGANIZATION;
36 using i18n::addressinput::POSTAL_CODE; 35 using i18n::addressinput::POSTAL_CODE;
37 using i18n::addressinput::RECIPIENT; 36 using i18n::addressinput::RECIPIENT;
38 using i18n::addressinput::RegionDataConstants; 37 using i18n::addressinput::RegionDataConstants;
39 using i18n::addressinput::Rule; 38 using i18n::addressinput::Rule;
40 using i18n::addressinput::STREET_ADDRESS; 39 using i18n::addressinput::STREET_ADDRESS;
41 40
41 bool IsFormatEmpty(const std::vector<std::vector<AddressField> >& format) {
42 for (std::vector<std::vector<AddressField> >::const_iterator
43 it = format.begin(); it != format.end(); ++it) {
44 if (!it->empty()) {
45 return false;
46 }
47 }
48 return true;
49 }
50
42 TEST(RuleTest, CopyOverwritesRule) { 51 TEST(RuleTest, CopyOverwritesRule) {
43 Rule rule; 52 Rule rule;
44 ASSERT_TRUE(rule.ParseSerializedRule("{" 53 ASSERT_TRUE(rule.ParseSerializedRule(
45 "\"fmt\":\"%S%Z\"," 54 "{"
46 "\"state_name_type\":\"area\"," 55 "\"fmt\":\"%S%Z\","
47 "\"zip_name_type\":\"postal\"," 56 "\"require\":\"SZ\","
48 "\"sub_keys\":\"CA~NY~TX\"," 57 "\"state_name_type\":\"area\","
49 "\"lang\":\"en\"," 58 "\"zip_name_type\":\"postal\","
50 "\"languages\":\"en~fr\"" 59 "\"sub_keys\":\"CA~NY~TX\","
51 "}")); 60 "\"lang\":\"en\","
61 "\"languages\":\"en~fr\","
62 "\"zip\":\"\\\\d{5}([ \\\\-]\\\\d{4})?\""
63 "}"));
52 64
53 Rule copy; 65 Rule copy;
54 EXPECT_NE(rule.GetFormat(), copy.GetFormat()); 66 EXPECT_NE(rule.GetFormat(), copy.GetFormat());
67 EXPECT_NE(rule.GetRequired(), copy.GetRequired());
55 EXPECT_NE(rule.GetSubKeys(), copy.GetSubKeys()); 68 EXPECT_NE(rule.GetSubKeys(), copy.GetSubKeys());
56 EXPECT_NE(rule.GetLanguages(), copy.GetLanguages()); 69 EXPECT_NE(rule.GetLanguages(), copy.GetLanguages());
57 EXPECT_NE(rule.GetLanguage(), copy.GetLanguage()); 70 EXPECT_NE(rule.GetLanguage(), copy.GetLanguage());
71 EXPECT_NE(rule.GetPostalCodeFormat(), copy.GetPostalCodeFormat());
58 EXPECT_NE(rule.GetAdminAreaNameMessageId(), 72 EXPECT_NE(rule.GetAdminAreaNameMessageId(),
59 copy.GetAdminAreaNameMessageId()); 73 copy.GetAdminAreaNameMessageId());
60 EXPECT_NE(rule.GetPostalCodeNameMessageId(), 74 EXPECT_NE(rule.GetPostalCodeNameMessageId(),
61 copy.GetPostalCodeNameMessageId()); 75 copy.GetPostalCodeNameMessageId());
62 76
63 copy.CopyFrom(rule); 77 copy.CopyFrom(rule);
64 EXPECT_EQ(rule.GetFormat(), copy.GetFormat()); 78 EXPECT_EQ(rule.GetFormat(), copy.GetFormat());
79 EXPECT_EQ(rule.GetRequired(), copy.GetRequired());
65 EXPECT_EQ(rule.GetSubKeys(), copy.GetSubKeys()); 80 EXPECT_EQ(rule.GetSubKeys(), copy.GetSubKeys());
66 EXPECT_EQ(rule.GetLanguages(), copy.GetLanguages()); 81 EXPECT_EQ(rule.GetLanguages(), copy.GetLanguages());
67 EXPECT_EQ(rule.GetLanguage(), copy.GetLanguage()); 82 EXPECT_EQ(rule.GetLanguage(), copy.GetLanguage());
83 EXPECT_EQ(rule.GetPostalCodeFormat(), copy.GetPostalCodeFormat());
68 EXPECT_EQ(rule.GetAdminAreaNameMessageId(), 84 EXPECT_EQ(rule.GetAdminAreaNameMessageId(),
69 copy.GetAdminAreaNameMessageId()); 85 copy.GetAdminAreaNameMessageId());
70 EXPECT_EQ(rule.GetPostalCodeNameMessageId(), 86 EXPECT_EQ(rule.GetPostalCodeNameMessageId(),
71 copy.GetPostalCodeNameMessageId()); 87 copy.GetPostalCodeNameMessageId());
72 } 88 }
73 89
74 TEST(RuleTest, ParseOverwritesRule) { 90 TEST(RuleTest, ParseOverwritesRule) {
75 Rule rule; 91 Rule rule;
76 ASSERT_TRUE(rule.ParseSerializedRule("{" 92 ASSERT_TRUE(rule.ParseSerializedRule(
77 "\"fmt\":\"%S%Z\"," 93 "{"
78 "\"state_name_type\":\"area\"," 94 "\"fmt\":\"%S%Z\","
79 "\"zip_name_type\":\"postal\"," 95 "\"require\":\"SZ\","
80 "\"sub_keys\":\"CA~NY~TX\"," 96 "\"state_name_type\":\"area\","
81 "\"lang\":\"en\"," 97 "\"zip_name_type\":\"postal\","
82 "\"languages\":\"en~fr\"" 98 "\"sub_keys\":\"CA~NY~TX\","
83 "}")); 99 "\"lang\":\"en\","
84 EXPECT_FALSE(rule.GetFormat().empty()); 100 "\"languages\":\"en~fr\","
101 "\"zip\":\"\\\\d{5}([ \\\\-]\\\\d{4})?\""
102 "}"));
103 EXPECT_FALSE(IsFormatEmpty(rule.GetFormat()));
104 EXPECT_FALSE(rule.GetRequired().empty());
85 EXPECT_FALSE(rule.GetSubKeys().empty()); 105 EXPECT_FALSE(rule.GetSubKeys().empty());
86 EXPECT_FALSE(rule.GetLanguages().empty()); 106 EXPECT_FALSE(rule.GetLanguages().empty());
87 EXPECT_FALSE(rule.GetLanguage().empty()); 107 EXPECT_FALSE(rule.GetLanguage().empty());
108 EXPECT_FALSE(rule.GetPostalCodeFormat().empty());
88 EXPECT_EQ(IDS_LIBADDRESSINPUT_I18N_AREA, 109 EXPECT_EQ(IDS_LIBADDRESSINPUT_I18N_AREA,
89 rule.GetAdminAreaNameMessageId()); 110 rule.GetAdminAreaNameMessageId());
90 EXPECT_EQ(IDS_LIBADDRESSINPUT_I18N_POSTAL_CODE_LABEL, 111 EXPECT_EQ(IDS_LIBADDRESSINPUT_I18N_POSTAL_CODE_LABEL,
91 rule.GetPostalCodeNameMessageId()); 112 rule.GetPostalCodeNameMessageId());
92 113
93 ASSERT_TRUE(rule.ParseSerializedRule("{" 114 ASSERT_TRUE(rule.ParseSerializedRule(
94 "\"fmt\":\"\"," 115 "{"
95 "\"state_name_type\":\"do_si\"," 116 "\"fmt\":\"\","
96 "\"zip_name_type\":\"zip\"," 117 "\"require\":\"\","
97 "\"sub_keys\":\"\"," 118 "\"state_name_type\":\"do_si\","
98 "\"lang\":\"\"," 119 "\"zip_name_type\":\"zip\","
99 "\"languages\":\"\"" 120 "\"sub_keys\":\"\","
100 "}")); 121 "\"lang\":\"\","
101 EXPECT_TRUE(rule.GetFormat().empty()); 122 "\"languages\":\"\","
123 "\"zip\":\"\""
124 "}"));
125 EXPECT_TRUE(IsFormatEmpty(rule.GetFormat()));
126 EXPECT_TRUE(rule.GetRequired().empty());
102 EXPECT_TRUE(rule.GetSubKeys().empty()); 127 EXPECT_TRUE(rule.GetSubKeys().empty());
103 EXPECT_TRUE(rule.GetLanguages().empty()); 128 EXPECT_TRUE(rule.GetLanguages().empty());
104 EXPECT_TRUE(rule.GetLanguage().empty()); 129 EXPECT_TRUE(rule.GetLanguage().empty());
130 EXPECT_TRUE(rule.GetPostalCodeFormat().empty());
105 EXPECT_EQ(IDS_LIBADDRESSINPUT_I18N_DO_SI, 131 EXPECT_EQ(IDS_LIBADDRESSINPUT_I18N_DO_SI,
106 rule.GetAdminAreaNameMessageId()); 132 rule.GetAdminAreaNameMessageId());
107 EXPECT_EQ(IDS_LIBADDRESSINPUT_I18N_ZIP_CODE_LABEL, 133 EXPECT_EQ(IDS_LIBADDRESSINPUT_I18N_ZIP_CODE_LABEL,
108 rule.GetPostalCodeNameMessageId()); 134 rule.GetPostalCodeNameMessageId());
109 } 135 }
110 136
111 TEST(RuleTest, ParsesFormatCorrectly) { 137 TEST(RuleTest, ParseFormatWithNewLines) {
112 Rule rule; 138 Rule rule;
113 ASSERT_TRUE(rule.ParseSerializedRule("{\"fmt\":\"%S\"}")); 139 ASSERT_TRUE(
114 ASSERT_EQ(1, rule.GetFormat().size()); 140 rule.ParseSerializedRule("{\"fmt\":\"%O%n%N%n%A%nAX-%Z %C%nĂ…LAND\"}"));
115 EXPECT_EQ(ADMIN_AREA, rule.GetFormat()[0]); 141 std::vector<std::vector<AddressField> > expected_format;
142 expected_format.push_back(std::vector<AddressField>(1, ORGANIZATION));
143 expected_format.push_back(std::vector<AddressField>(1, RECIPIENT));
144 expected_format.push_back(std::vector<AddressField>(1, STREET_ADDRESS));
145 expected_format.push_back(std::vector<AddressField>(1, POSTAL_CODE));
146 expected_format.back().push_back(LOCALITY);
147 expected_format.push_back(std::vector<AddressField>());
148 EXPECT_EQ(expected_format, rule.GetFormat());
149 }
150
151 TEST(RuleTest, DoubleTokenPrefixDoesNotCrash) {
152 Rule rule;
153 EXPECT_TRUE(rule.ParseSerializedRule("{\"fmt\":\"%%R\"}"));
154 }
155
156 TEST(RuleTest, DoubleNewlineFormatDoesNotCrash) {
157 Rule rule;
158 EXPECT_TRUE(rule.ParseSerializedRule("{\"fmt\":\"%n%n\"}"));
159 }
160
161 TEST(RuleTest, FormatTokenWithoutPrefixDoesNotCrash) {
162 Rule rule;
163 ASSERT_TRUE(rule.ParseSerializedRule("{\"fmt\":\"R\"}"));
164 }
165
166 TEST(RuleTest, ParseDuplicateTokenInFormatDoesNotCrash) {
167 Rule rule;
168 EXPECT_TRUE(rule.ParseSerializedRule("{\"fmt\":\"%R%R\"}"));
169 }
170
171 TEST(RuleTest, ParseInvalidFormatFieldsDoesNotCrash) {
172 Rule rule;
173 EXPECT_TRUE(rule.ParseSerializedRule("{\"fmt\":\"%K%L\"}"));
174 }
175
176 TEST(RuleTest, PrefixWithoutTokenFormatDoesNotCrash) {
177 Rule rule;
178 EXPECT_TRUE(rule.ParseSerializedRule("{\"fmt\":\"%\"}"));
179 }
180
181 TEST(RuleTest, EmptyStringFormatDoesNotCrash) {
182 Rule rule;
183 EXPECT_TRUE(rule.ParseSerializedRule("{\"fmt\":\"\"}"));
184 }
185
186 TEST(RuleTest, ParseRequiredFields) {
187 Rule rule;
188 ASSERT_TRUE(rule.ParseSerializedRule("{\"require\":\"ONAZC\"}"));
189 std::vector<AddressField> expected;
190 expected.push_back(ORGANIZATION);
191 expected.push_back(RECIPIENT);
192 expected.push_back(STREET_ADDRESS);
193 expected.push_back(POSTAL_CODE);
194 expected.push_back(LOCALITY);
195 EXPECT_EQ(expected, rule.GetRequired());
196 }
197
198 TEST(RuleTest, ParseEmptyStringRequiredFields) {
199 Rule rule;
200 ASSERT_TRUE(rule.ParseSerializedRule("{\"require\":\"\"}"));
201 EXPECT_TRUE(rule.GetRequired().empty());
202 }
203
204 TEST(RuleTest, ParseInvalidRequiredFields) {
205 Rule rule;
206 ASSERT_TRUE(rule.ParseSerializedRule("{\"require\":\"garbage\"}"));
207 EXPECT_TRUE(rule.GetRequired().empty());
208 }
209
210 TEST(RuleTest, ParseDuplicateRequiredFields) {
211 Rule rule;
212 ASSERT_TRUE(rule.ParseSerializedRule("{\"require\":\"SSS\"}"));
213 EXPECT_EQ(std::vector<AddressField>(3, ADMIN_AREA), rule.GetRequired());
116 } 214 }
117 215
118 TEST(RuleTest, ParsesSubKeysCorrectly) { 216 TEST(RuleTest, ParsesSubKeysCorrectly) {
119 Rule rule; 217 Rule rule;
120 ASSERT_TRUE(rule.ParseSerializedRule("{\"sub_keys\":\"CA~NY~TX\"}")); 218 ASSERT_TRUE(rule.ParseSerializedRule("{\"sub_keys\":\"CA~NY~TX\"}"));
121 std::vector<std::string> expected; 219 std::vector<std::string> expected;
122 expected.push_back("CA"); 220 expected.push_back("CA");
123 expected.push_back("NY"); 221 expected.push_back("NY");
124 expected.push_back("TX"); 222 expected.push_back("TX");
125 EXPECT_EQ(expected, rule.GetSubKeys()); 223 EXPECT_EQ(expected, rule.GetSubKeys());
126 } 224 }
127 225
128 TEST(RuleTest, ParsesLanguageCorrectly) { 226 TEST(RuleTest, ParsesLanguageCorrectly) {
129 Rule rule; 227 Rule rule;
130 ASSERT_TRUE(rule.ParseSerializedRule("{\"lang\":\"en\"}")); 228 ASSERT_TRUE(rule.ParseSerializedRule("{\"lang\":\"en\"}"));
131 EXPECT_EQ("en", rule.GetLanguage()); 229 EXPECT_EQ("en", rule.GetLanguage());
132 } 230 }
133 231
134 TEST(RuleTest, ParsesLanguagesCorrectly) { 232 TEST(RuleTest, ParsesLanguagesCorrectly) {
135 Rule rule; 233 Rule rule;
136 ASSERT_TRUE(rule.ParseSerializedRule("{\"languages\":\"de~fr~it\"}")); 234 ASSERT_TRUE(rule.ParseSerializedRule("{\"languages\":\"de~fr~it\"}"));
137 std::vector<std::string> expected; 235 std::vector<std::string> expected;
138 expected.push_back("de"); 236 expected.push_back("de");
139 expected.push_back("fr"); 237 expected.push_back("fr");
140 expected.push_back("it"); 238 expected.push_back("it");
141 EXPECT_EQ(expected, rule.GetLanguages()); 239 EXPECT_EQ(expected, rule.GetLanguages());
142 } 240 }
143 241
242 TEST(RuleTest, ParsesPostalCodeFormatCorrectly) {
243 Rule rule;
244 ASSERT_TRUE(rule.ParseSerializedRule(
245 "{"
246 "\"zip\":\"\\\\d{5}([ \\\\-]\\\\d{4})?\""
247 "}"));
248 EXPECT_EQ("\\d{5}([ \\-]\\d{4})?", rule.GetPostalCodeFormat());
249 }
250
144 TEST(RuleTest, EmptyStringIsNotValid) { 251 TEST(RuleTest, EmptyStringIsNotValid) {
145 Rule rule; 252 Rule rule;
146 EXPECT_FALSE(rule.ParseSerializedRule(std::string())); 253 EXPECT_FALSE(rule.ParseSerializedRule(std::string()));
147 } 254 }
148 255
149 TEST(RuleTest, EmptyDictionaryIsValid) { 256 TEST(RuleTest, EmptyDictionaryIsValid) {
150 Rule rule; 257 Rule rule;
151 EXPECT_TRUE(rule.ParseSerializedRule("{}")); 258 EXPECT_TRUE(rule.ParseSerializedRule("{}"));
152 } 259 }
153 260
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 EXPECT_TRUE(rule_.ParseSerializedRule( 331 EXPECT_TRUE(rule_.ParseSerializedRule(
225 RegionDataConstants::GetRegionData(GetParam()))); 332 RegionDataConstants::GetRegionData(GetParam())));
226 } 333 }
227 334
228 // Test parsing all region data. 335 // Test parsing all region data.
229 INSTANTIATE_TEST_CASE_P( 336 INSTANTIATE_TEST_CASE_P(
230 AllRulesTest, RuleParseTest, 337 AllRulesTest, RuleParseTest,
231 testing::ValuesIn(RegionDataConstants::GetRegionCodes())); 338 testing::ValuesIn(RegionDataConstants::GetRegionCodes()));
232 339
233 } // namespace 340 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698