Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1067623002: Speed up key_silk_cases masonry, re-layout x30 for stability (Closed)

Created:
5 years, 8 months ago by benjhayden
Modified:
5 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speed up key_silk_cases masonry page so it doesn't mask regressions in other pages. Re-layout 30 times so that averages are more stable. CL for perf tryjob: https://codereview.chromium.org/1064683002 https://codereview.chromium.org/1064723002 Committed: https://crrev.com/9cd6e0dccc8918b56d2d38bf1cbc72bfa3e324fd Cr-Commit-Position: refs/heads/master@{#324259}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : relayout x10 for stability #

Patch Set 4 : relayout x30 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M tools/perf/page_sets/key_silk_cases/masonry.html View 1 2 3 2 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
benjhayden
5 years, 8 months ago (2015-04-06 21:36:52 UTC) #2
nednguyen
lgtm +Sheriff, this may cause regression.
5 years, 8 months ago (2015-04-06 21:46:03 UTC) #4
benjhayden
Sorry, Ned, re-review? Patch 2 does layout 10 times for stability.
5 years, 8 months ago (2015-04-06 22:09:00 UTC) #6
nednguyen
On 2015/04/06 22:09:00, benjhayden_chromium wrote: > Sorry, Ned, re-review? > Patch 2 does layout 10 ...
5 years, 8 months ago (2015-04-06 22:14:38 UTC) #7
benjhayden
On 2015/04/06 at 22:14:38, nednguyen wrote: > On 2015/04/06 22:09:00, benjhayden_chromium wrote: > > Sorry, ...
5 years, 8 months ago (2015-04-06 23:09:06 UTC) #8
nednguyen
On 2015/04/06 23:09:06, benjhayden_chromium wrote: > On 2015/04/06 at 22:14:38, nednguyen wrote: > > On ...
5 years, 8 months ago (2015-04-06 23:29:49 UTC) #9
nednguyen
On 2015/04/06 23:09:06, benjhayden_chromium wrote: > On 2015/04/06 at 22:14:38, nednguyen wrote: > > On ...
5 years, 8 months ago (2015-04-06 23:29:50 UTC) #10
vmiura
How stable is the metric with 10 reps? 30 or 60 seems reasonable too. Otherwise ...
5 years, 8 months ago (2015-04-07 02:29:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067623002/80001
5 years, 8 months ago (2015-04-08 17:12:11 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 8 months ago (2015-04-08 18:47:29 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 18:48:28 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9cd6e0dccc8918b56d2d38bf1cbc72bfa3e324fd
Cr-Commit-Position: refs/heads/master@{#324259}

Powered by Google App Engine
This is Rietveld 408576698