Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1067593007: Chromecast: removes ATV product information from UA string. (Closed)

Created:
5 years, 8 months ago by gunsch
Modified:
5 years, 8 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: removes ATV product information from UA string. R=lcwu@chromium.org,byungchu@chromium.org BUG=internal b/20398673 Committed: https://crrev.com/45d0df260fc8254c7743bcbcab92eec17b57fb92 Cr-Commit-Position: refs/heads/master@{#326139}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Linux --> X11 for non-Android case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M chromecast/common/cast_content_client.cc View 1 2 chunks +50 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
gunsch
5 years, 8 months ago (2015-04-21 20:38:35 UTC) #1
gunsch
Before: Mozilla/5.0 (Linux; Android 5.1.1; Nexus Player Build/LMY47U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.24 Safari/537.36 CrKey/1.14.20150421.120106 ...
5 years, 8 months ago (2015-04-21 20:43:57 UTC) #3
gunsch
Whoops, bad copy/paste; mixed up my strings. Before: Mozilla/5.0 (Linux; Android 5.1.1; Nexus Player Build/LMY47U) ...
5 years, 8 months ago (2015-04-21 20:44:39 UTC) #4
lcwu1
https://codereview.chromium.org/1067593007/diff/1/chromecast/common/cast_content_client.cc File chromecast/common/cast_content_client.cc (right): https://codereview.chromium.org/1067593007/diff/1/chromecast/common/cast_content_client.cc#newcode58 chromecast/common/cast_content_client.cc:58: "Linux; ", In the current user agent string, this ...
5 years, 8 months ago (2015-04-21 20:55:04 UTC) #5
gunsch
https://codereview.chromium.org/1067593007/diff/1/chromecast/common/cast_content_client.cc File chromecast/common/cast_content_client.cc (right): https://codereview.chromium.org/1067593007/diff/1/chromecast/common/cast_content_client.cc#newcode58 chromecast/common/cast_content_client.cc:58: "Linux; ", On 2015/04/21 20:55:04, lcwu1 wrote: > In ...
5 years, 8 months ago (2015-04-21 21:04:32 UTC) #6
lcwu1
lgtm
5 years, 8 months ago (2015-04-21 21:37:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067593007/20001
5 years, 8 months ago (2015-04-21 21:39:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 22:01:15 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 22:02:04 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/45d0df260fc8254c7743bcbcab92eec17b57fb92
Cr-Commit-Position: refs/heads/master@{#326139}

Powered by Google App Engine
This is Rietveld 408576698