Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1067593006: Implement material throbber and use it in one place (Autofill card (Closed)

Created:
5 years, 8 months ago by Evan Stade
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement material throbber and use it in one place (Autofill card unmasking prompt). BUG=473342 Committed: https://crrev.com/89cf95f6e0432b0bf17e5b67f2b395ae69f2ae3e Cr-Commit-Position: refs/heads/master@{#326275}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 8

Patch Set 3 : sky review #

Patch Set 4 : fix win compile? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -41 lines) Patch
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/throbber.h View 1 2 2 chunks +22 lines, -14 lines 0 comments Download
M ui/views/controls/throbber.cc View 1 2 3 3 chunks +76 lines, -24 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Evan Stade
re: performance - My unscientific testing on my local machine shows that the normal throbber ...
5 years, 8 months ago (2015-04-21 20:07:39 UTC) #2
sky
Make sure you also try this at non-1x scales to make sure it looks good. ...
5 years, 8 months ago (2015-04-21 20:17:38 UTC) #3
Evan Stade
looks good with --force-device-scale-factor=2 https://codereview.chromium.org/1067593006/diff/20001/ui/views/controls/throbber.h File ui/views/controls/throbber.h (right): https://codereview.chromium.org/1067593006/diff/20001/ui/views/controls/throbber.h#newcode44 ui/views/controls/throbber.h:44: const base::Time& start_time() { return ...
5 years, 8 months ago (2015-04-21 22:04:02 UTC) #4
sky
I still like set_preferred_size(int), but ok, LGTM
5 years, 8 months ago (2015-04-21 23:41:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067593006/40001
5 years, 8 months ago (2015-04-21 23:50:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/45030)
5 years, 8 months ago (2015-04-22 00:26:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067593006/60001
5 years, 8 months ago (2015-04-22 12:34:24 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-22 12:38:10 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 12:39:01 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/89cf95f6e0432b0bf17e5b67f2b395ae69f2ae3e
Cr-Commit-Position: refs/heads/master@{#326275}

Powered by Google App Engine
This is Rietveld 408576698