chrome/browser/ui/app_list/search/common/url_icon_source.cc - Issue 1067593005: Fix race conditions in ImageDecoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/common/url_icon_source.cc

Issue 1067593005: Fix race conditions in ImageDecoder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use TestBrowserThreadBundle, cleanup tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/search/common/url_icon_source.cc

diff --git a/chrome/browser/ui/app_list/search/common/url_icon_source.cc b/chrome/browser/ui/app_list/search/common/url_icon_source.cc

index 3dccf5336728f4502a1c11dc26fad9a0051d6c38..daa404614f2d7419da114393923d05a84cd45def 100644

--- a/chrome/browser/ui/app_list/search/common/url_icon_source.cc

+++ b/chrome/browser/ui/app_list/search/common/url_icon_source.cc

@@ -22,9 +22,7 @@ UrlIconSource::UrlIconSource(const IconLoadedCallback& icon_loaded_callback,

const GURL& icon_url,

int icon_size,

int default_icon_resource_id)

- : ImageRequest(

- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI)),

- icon_loaded_callback_(icon_loaded_callback),

+ : icon_loaded_callback_(icon_loaded_callback),

context_getter_(context_getter),

icon_url_(icon_url),

icon_size_(icon_size),