chrome/browser/android/logo_service.cc - Issue 1067593005: Fix race conditions in ImageDecoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/logo_service.cc

Issue 1067593005: Fix race conditions in ImageDecoder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use TestBrowserThreadBundle, cleanup tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/logo_service.cc

diff --git a/chrome/browser/android/logo_service.cc b/chrome/browser/android/logo_service.cc

index c71cefd97053aa4abaa931a09782f7a28be011fa..fc113ff774742d5e0cc73e83557d3438c65fcfc1 100644

--- a/chrome/browser/android/logo_service.cc

+++ b/chrome/browser/android/logo_service.cc

@@ -40,8 +40,7 @@ class LogoDecoderDelegate : public ImageDecoder::ImageRequest {

public:

LogoDecoderDelegate(

const base::Callback<void(const SkBitmap&)>& image_decoded_callback)

- : ImageRequest(base::MessageLoopProxy::current()),

- image_decoded_callback_(image_decoded_callback),

+ : image_decoded_callback_(image_decoded_callback),

weak_ptr_factory_(this) {

// If the ImageDecoder crashes or otherwise never completes, call

// OnImageDecodeTimedOut() eventually to ensure that image_decoded_callback_

« no previous file with comments | « no previous file | chrome/browser/apps/drive/drive_app_converter.cc » ('j') | no next file with comments »