tools/telemetry/telemetry/wpr/archive_info.py - Issue 1067583004: Upload to the hash location instead of the file_name on record_wpr upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/wpr/archive_info.py

Issue 1067583004: Upload to the hash location instead of the file_name on record_wpr upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/wpr/archive_info.py

diff --git a/tools/telemetry/telemetry/wpr/archive_info.py b/tools/telemetry/telemetry/wpr/archive_info.py

index e90ae5e834a4d3390436de55e5fc8cd6ce462267..3468ed1e775f7808cb0018b6e95f4bb6332b9cd1 100644

--- a/tools/telemetry/telemetry/wpr/archive_info.py

+++ b/tools/telemetry/telemetry/wpr/archive_info.py

@@ -127,8 +127,9 @@ class WprArchiveInfo(object):

shutil.move(self.temp_target_wpr_file_path, target_wpr_file_path)

# Update the hash file.

+ target_wpr_file_hash = cloud_storage.CalculateHash(target_wpr_file_path)

with open(target_wpr_file_path + '.sha1', 'wb') as f:

- f.write(cloud_storage.CalculateHash(target_wpr_file_path))

+ f.write(target_wpr_file_hash)

f.flush()

self._WriteToFile()

@@ -141,7 +142,7 @@ class WprArchiveInfo(object):

'user stories to cloud storage.')

return

try:

- cloud_storage.Insert(self._bucket, target_wpr_file,

+ cloud_storage.Insert(self._bucket, target_wpr_file_hash,

target_wpr_file_path)

except cloud_storage.CloudStorageError, e:

logging.warning('Failed to upload wpr file %s to cloud storage. '

« no previous file with comments | « no previous file | no next file » | no next file with comments »