Factor out reporting from rules

lib/src/codegen/dart_codegen.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.codegen.dart_codegen;
 
 import 'dart:io' show File;
 
 import 'package:analyzer/analyzer.dart' as analyzer;
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/java_core.dart' as java_core;
 import 'package:analyzer/src/generated/scanner.dart' show Token;
 import 'package:dart_style/dart_style.dart';
 import 'package:logging/logging.dart' as logger;
 import 'package:path/path.dart' as path;
 
 import 'package:dev_compiler/src/info.dart';
 import 'package:dev_compiler/src/checker/rules.dart';
 import 'package:dev_compiler/src/options.dart';
-import 'package:dev_compiler/src/report.dart';
 import 'package:dev_compiler/src/utils.dart' as utils;
 import 'ast_builder.dart';
 import 'code_generator.dart' as codegenerator;
 import 'reify_coercions.dart' as reifier;
 
 final _log = new logger.Logger('dev_compiler.dart_codegen');
 
 class DevCompilerRuntime {
   Identifier _runtimeId = AstBuilder.identifierFromString("DEVC\$RT");
 
@@ skipping 396 matching lines @@
         options, path.join(libraryDir, '${uri.pathSegments.last}'));
     var tm = new reifier.TypeManager(_vm);
     var r = new reifier.UnitCoercionReifier(tm, _vm, _rules);
     r.reify(unit);
     var ids = new Set<Identifier>.from(tm.addedTypes.map((tn) => tn.name));
     var unitGen = new UnitGenerator(unit, out, outDir, _extraImports, ids);
     unitGen.generate();
     out.finalize();
   }
 
-  String generateLibrary(
-      LibraryUnit library, LibraryInfo info, CheckerReporter reporter) {
+  String generateLibrary(LibraryUnit library, LibraryInfo info) {
     _vm = new reifier.VariableManager();
     _extraImports = new Set<LibraryElement>();
 
     for (var unit in library.partsThenLibrary) {
       var outputDir = makeOutputDirectory(info, unit);
-      reporter.enterSource(unit.element.source);
       generateUnit(unit, info, outputDir);
-      reporter.leaveSource();
     }
 
     _extraImports = null;
     _vm = null;
     return null;
   }
 }
 
 class EmptyUnitGenerator extends UnitGeneratorCommon {
   final java_core.PrintWriter _out;
@@ skipping 11 matching lines @@
   }
 }
 
 // This class emits the code unchanged, for comparison purposes.
 class EmptyDartGenerator extends codegenerator.CodeGenerator {
   final CompilerOptions options;
 
   EmptyDartGenerator(String outDir, Uri root, TypeRules rules, this.options)
       : super(outDir, root, rules);
 
-  String generateLibrary(
-      LibraryUnit library, LibraryInfo info, CheckerReporter reporter) {
+  String generateLibrary(LibraryUnit library, LibraryInfo info) {
     for (var unit in library.partsThenLibrary) {
       var outputDir = makeOutputDirectory(info, unit);
-      reporter.enterSource(unit.element.source);
       generateUnit(unit, info, outputDir);
-      reporter.leaveSource();
     }
     return null;
   }
 
   void generateUnit(CompilationUnit unit, LibraryInfo info, String libraryDir) {
     var uri = unit.element.source.uri;
     _log.fine("Emitting original unit " + uri.toString());
     FileWriter out = new FileWriter(
         options, path.join(libraryDir, '${uri.pathSegments.last}'));
     var unitGen = new EmptyUnitGenerator(unit, out);
     unitGen.generate();
     out.finalize();
   }
 }