Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1067523003: Wrap array implementation in a function. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Wrap array implementation in a function. R=jkummerow@chromium.org Committed: https://crrev.com/f66a31282afc26d3c5ca477a4409e43faabb6029 Cr-Commit-Position: refs/heads/master@{#27940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -125 lines) Patch
M src/array.js View 11 chunks +118 lines, -93 lines 0 comments Download
M src/builtins.cc View 21 chunks +31 lines, -31 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Yang
5 years, 8 months ago (2015-04-20 13:08:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067523003/1
5 years, 8 months ago (2015-04-20 13:09:06 UTC) #3
Jakob Kummerow
lgtm
5 years, 8 months ago (2015-04-20 13:11:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067523003/1
5 years, 8 months ago (2015-04-20 13:34:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-20 14:12:43 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 14:12:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f66a31282afc26d3c5ca477a4409e43faabb6029
Cr-Commit-Position: refs/heads/master@{#27940}

Powered by Google App Engine
This is Rietveld 408576698