LayoutTests/http/tests/serviceworker/install-event-type.html - Issue 1067513002: Removing ServiceWorker's InstallEvent Interface.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/install-event-type.html

Issue 1067513002: Removing ServiceWorker's InstallEvent Interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/resources/install-event-type.js » ('j') | LayoutTests/http/tests/serviceworker/resources/install-event-type.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharness-helpers.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="resources/test-helpers.js"></script>

	6 <script>

	7 function wait_for_install_event(worker) {

	8 return new Promise(function(resolve) {

	9 worker.addEventListener('statechange', function(event) {

	10 if (worker.state == 'installed')

	11 resolve(true);

	12 else if (worker.state == 'redundant')

	13 resolve(false);

	14 });

	15 });

	16 }

	17

	18 promise_test(function(t) {

	19 return service_worker_unregister_and_register(t, 'resources/oninstall-even t-type.js', 'resources/oninstall-event-type.js')
	falken 2015/04/08 05:44:46 By convention, service worker script filenames end By convention, service worker script filenames end with "-worker.js" It's also nice to give the scope a name similar to the test name and pass that: var scope = 'install-event-type' Also, please wrap lines at 80 cols: https://www.chromium.org/blink/serviceworker/testing Paritosh Kumar 2015/04/08 06:44:06 Thanks. Done. OO, I was using 'resources/oninstal Thanks. Done. OO, I was using 'resources/oninstall-event-type.js' instead of 'resources/install-event-type.js'. given scope name similar to test name.
	20 .then(function(registration) {

	21 return wait_for_install_event(registration.installing);

	22 })

	23 .then(function(did_install) {

	24 assert_equals(did_install, true,'The worker was installed');
	falken 2015/04/08 05:44:46 You can use assert_true rather than assert_equals You can use assert_true rather than assert_equals Also it's missing a space after the comma Paritosh Kumar 2015/04/08 06:44:06 Yeah.. Thanks. Show quoted text On 2015/04/08 05:44:46, falken wrote: > You can use assert_true rather than assert_equals > > Also it's missing a space after the comma Yeah.. Thanks.
	25 })

	26 }, 'install event type');

	27

	28 </script>

	29
	falken 2015/04/08 05:44:46 nit: extra empty line nit: extra empty line Paritosh Kumar 2015/04/08 06:44:06 Done. Show quoted text On 2015/04/08 05:44:46, falken wrote: > nit: extra empty line Done.
OLD	NEW