Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1067503002: [Oilpan] Move global definitions into a scoped area (Closed)

Created:
5 years, 8 months ago by peria
Modified:
5 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This is a refactoring CL of oilpan_gc_times.py Move getGCReason() and two string definitions into _AddTracingResults() BUG=438074 TEST=./tools/perf/run_tests oilpan --browser=content-shell-release Committed: https://crrev.com/e3d26c5c798010a1214ac9a8c2ffaad45340438e Cr-Commit-Position: refs/heads/master@{#323899}

Patch Set 1 #

Patch Set 2 : Fix tests #

Total comments: 2

Patch Set 3 : Fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M tools/perf/measurements/oilpan_gc_times.py View 1 2 3 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
peria
PTL. This is a trivial CL.
5 years, 8 months ago (2015-04-06 06:42:35 UTC) #2
keishi
https://codereview.chromium.org/1067503002/diff/20001/tools/perf/measurements/oilpan_gc_times.py File tools/perf/measurements/oilpan_gc_times.py (right): https://codereview.chromium.org/1067503002/diff/20001/tools/perf/measurements/oilpan_gc_times.py#newcode62 tools/perf/measurements/oilpan_gc_times.py:62: # Parse tarce events nit: /tarce/trace/
5 years, 8 months ago (2015-04-06 07:00:09 UTC) #4
peria
https://codereview.chromium.org/1067503002/diff/20001/tools/perf/measurements/oilpan_gc_times.py File tools/perf/measurements/oilpan_gc_times.py (right): https://codereview.chromium.org/1067503002/diff/20001/tools/perf/measurements/oilpan_gc_times.py#newcode62 tools/perf/measurements/oilpan_gc_times.py:62: # Parse tarce events On 2015/04/06 07:00:08, keishi wrote: ...
5 years, 8 months ago (2015-04-06 07:06:01 UTC) #5
haraken
LGTM
5 years, 8 months ago (2015-04-06 07:06:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067503002/40001
5 years, 8 months ago (2015-04-06 07:11:22 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-06 09:07:07 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 09:07:53 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e3d26c5c798010a1214ac9a8c2ffaad45340438e
Cr-Commit-Position: refs/heads/master@{#323899}

Powered by Google App Engine
This is Rietveld 408576698