OOPIF: Allow OOP frames to print console messages in layout tests.

content/common/swapped_out_messages.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/swapped_out_messages.h"
 
 #include "content/common/accessibility_messages.h"
 #include "content/common/frame_messages.h"
 #include "content/common/input_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/common/content_client.h"
+#include "content/shell/common/shell_messages.h"
 
 namespace content {
 
 bool SwappedOutMessages::CanSendWhileSwappedOut(const IPC::Message* msg) {
   // We filter out most IPC messages when swapped out.  However, some are
   // important (e.g., ACKs) for keeping the browser and renderer state
   // consistent in case we later return to the same renderer.
   switch (msg->type()) {
     // Handled by RenderWidgetHost.
     case InputHostMsg_HandleInputEvent_ACK::ID:
@@ skipping 18 matching lines @@
     case FrameHostMsg_Detach::ID:
     case FrameHostMsg_DomOperationResponse::ID:
     case FrameHostMsg_CompositorFrameSwappedACK::ID:
     case FrameHostMsg_ReclaimCompositorResources::ID:
     // Input events propagate from parent to child.
     case FrameHostMsg_ForwardInputEvent::ID:
     case FrameHostMsg_InitializeChildFrame::ID:
     // The browser should always have an accurate mirror of the renderer's
     // notion of the current page id.
     case FrameHostMsg_DidAssignPageId::ID:
+    // Used in layout tests; handled in WebKitTestController.
+    case ShellViewHostMsg_PrintMessage::ID:

[dcheng, 2015/04/09 01:08:55]

Would it make sense to tie this to the --site-per-process flag?

[Charlie Reis, 2015/04/09 17:32:25]

There's nothing in Chrome that processes this message, so it's not an issue for
Chrome builds.

We could tie it to --site-per-process if you're concerned that existing tests
might fail due to swapped out RVHs sending console messages, but that seems
unlikely to me.  Layout tests don't really do many (any?) cross-process
navigations.

I think this is fine until we move WebKitTestRunner from RenderView to
RenderFrame.

[dcheng, 2015/04/09 17:37:31]

sgtm

       return true;
     default:
       break;
   }
 
   // Check with the embedder as well.
   ContentClient* client = GetContentClient();
   return client->CanSendWhileSwappedOut(msg);
 }
 
@@ skipping 30 matching lines @@
     case AccessibilityHostMsg_Events::ID:
       return true;
     default:
       break;
   }
 
   return false;
 }
 
 }  // namespace content