Tweaks for Element encoding and decoding.

pkg/analysis_server/lib/src/services/index/store/codec.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.src.index.store.codec;
 
 import 'dart:collection';
 
 import 'package:analysis_server/src/services/index/index.dart';
 import 'package:analyzer/src/generated/element.dart';
@@ skipping 104 matching lines @@
           }
           return element;
         }
       }
     }
     return null;
   }
 
   /**
    * Returns the first component of the [element] id.
+   * In the most cases it is an encoding of the [element]'s file path.

[Brian Wilkerson, 2015/04/09 16:01:25]

This should say when it isn't (an encoding of the [element]'s file path) and
what it is in those cases.

    */
   int encode1(Element element) {
     Source source = element.source;
     if (source == null) {
       return NAMED_FILE_ID;
     }
     String filePath = source.fullName;
     return _stringCodec.encode(filePath);
   }
 
   /**
    * Returns the second component of the [element] id.
+   * In the most cases it is the [element]'s name offset.
    */
   int encode2(Element element) {
     if (element is NameElement) {
       String name = element.name;
       return _stringCodec.encode(name);
     }
     if (element is ConstructorElement) {
       return element.enclosingElement.nameOffset;
     }
     return element.nameOffset;
   }
 
   /**
    * Returns the third component of the [element] id.
+   * In the most cases it is the [element]'s kind.
    */
   int encode3(Element element) {
     if (element is NameElement) {
       return NAMED_KIND_ID;
     }
     if (element is ConstructorElement) {
       ClassElement classElement = element.enclosingElement;
       int constructorIndex = classElement.constructors.indexOf(element);
       return _CONSTRUCTOR_KIND_BASE - constructorIndex;
     }
@@ skipping 61 matching lines @@
   int encode(String name) {
     int index = nameToIndex[name];
     if (index == null) {
       index = _indexToName.length;
       nameToIndex[name] = index;
       _indexToName.add(name);
     }
     return index;
   }
 }