Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 106733005: Update overlay scrollbars (Closed)

Created:
6 years, 11 months ago by DaveMoore
Modified:
6 years, 11 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Compute solid-color scrollbar properties on all platforms. It's unnecessary to gate solid-color scrollbar properties on whether the root container masks to bounds, since the vertical adjust should resolve to zero in this case anyway. It's necessary to set VisibleToTotalLengthRatio for desktop overlay scrollbars to be sized correctly. BUG=331605 TEST=None R=aelias Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243721

Patch Set 1 #

Patch Set 2 : Add IsThumbResizable() method to allow PaintedScrollbarLayerImpl to avoid paint damage when ratio c… #

Total comments: 1

Patch Set 3 : Comment change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M cc/layers/painted_scrollbar_layer_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M cc/layers/scrollbar_layer_impl_base.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/scrollbar_layer_impl_base.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
DaveMoore
6 years, 11 months ago (2014-01-03 23:34:15 UTC) #1
aelias_OOO_until_Jul13
lgtm. I went ahead and updated your patch description to explain what this is doing.
6 years, 11 months ago (2014-01-06 23:58:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/106733005/1
6 years, 11 months ago (2014-01-07 00:03:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) cc_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=210408
6 years, 11 months ago (2014-01-07 10:08:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/106733005/1
6 years, 11 months ago (2014-01-07 15:07:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/106733005/1
6 years, 11 months ago (2014-01-07 15:29:22 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) cc_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=210618
6 years, 11 months ago (2014-01-07 16:37:47 UTC) #7
aelias_OOO_until_Jul13
Looks like the extra NoteLayerPropertyChanged is causing extra damage that makes the unit tests fail. ...
6 years, 11 months ago (2014-01-07 19:45:40 UTC) #8
DaveMoore
Add IsThumbResizable() method to allow PaintedScrollbarLayerImpl to avoid paint damage when ratio changed
6 years, 11 months ago (2014-01-08 21:16:57 UTC) #9
DaveMoore
PTAL: added IsThumbResizable() method to allow PaintedScrollbarLayerImpl to avoid extra paints.
6 years, 11 months ago (2014-01-08 21:18:20 UTC) #10
aelias_OOO_until_Jul13
lgtm https://codereview.chromium.org/106733005/diff/500001/cc/layers/scrollbar_layer_impl_base.h File cc/layers/scrollbar_layer_impl_base.h (right): https://codereview.chromium.org/106733005/diff/500001/cc/layers/scrollbar_layer_impl_base.h#newcode67 cc/layers/scrollbar_layer_impl_base.h:67: // Indicates whether the thumb represents the visible ...
6 years, 11 months ago (2014-01-08 22:30:17 UTC) #11
DaveMoore
Comment change
6 years, 11 months ago (2014-01-08 22:35:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/106733005/570001
6 years, 11 months ago (2014-01-08 22:37:27 UTC) #13
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 01:11:37 UTC) #14
Message was sent while issue was closed.
Change committed as 243721

Powered by Google App Engine
This is Rietveld 408576698