Issue 106733002: Improve check elimination with branch sensitivity on HCompareObjectEqAndBranch.

Issue 106733002: Improve check elimination with branch sensitivity on HCompareObjectEqAndBranch. (Closed)

Created:
7 years ago by titzer

Modified:
7 years ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve check elimination with branch sensitivity on HCompareObjectEqAndBranch. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18377

Patch Set 2 : Split variable declarations onto multiple lines. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -23 lines)			Patch
M	src/hydrogen-check-elimination.cc	View	1	2 chunks	+29 lines, -4 lines	0 comments	Download
M	src/unique.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/compiler/compare_objeq_elim.js	View		1 chunk	+52 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

titzer

https://codereview.chromium.org/106733002/diff/1/src/hydrogen-check-elimination.cc File src/hydrogen-check-elimination.cc (right): https://codereview.chromium.org/106733002/diff/1/src/hydrogen-check-elimination.cc#newcode131 src/hydrogen-check-elimination.cc:131: copy->size_ = size_; Note that I missed these two ...

7 years ago (2013-12-05 15:45:00 UTC) #1

mvstanton

One nit, and LGTM. https://codereview.chromium.org/106733002/diff/1/src/hydrogen-check-elimination.cc File src/hydrogen-check-elimination.cc (right): https://codereview.chromium.org/106733002/diff/1/src/hydrogen-check-elimination.cc#newcode155 src/hydrogen-check-elimination.cc:155: HCheckTableEntry* le = copy->Find(left), *re ...

7 years ago (2013-12-06 09:46:16 UTC) #2

titzer

On 2013/12/06 09:46:16, mvstanton wrote: > One nit, and LGTM. > > https://codereview.chromium.org/106733002/diff/1/src/hydrogen-check-elimination.cc > File ...

7 years ago (2013-12-06 09:52:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r18377 (presubmit successful).

Expand Messages | Collapse Messages