Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1067303002: [ServiceWorker] Treat cors response as a network error for client requests. (Closed)

Created:
5 years, 8 months ago by horo
Modified:
5 years, 1 month ago
Reviewers:
falken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Treat cors response as a network error for client requests. The fetch spec has changed. https://github.com/whatwg/fetch/commit/9b4754b9929f2863b39ad7b7382ff206bdfa89a8 Spec issue: https://github.com/slightlyoff/ServiceWorker/issues/590 BUG=474914 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193776

Patch Set 1 : #

Total comments: 1

Patch Set 2 : wrap the line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M LayoutTests/http/tests/serviceworker/fetch-frame-resource.html View 3 chunks +21 lines, -14 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 1 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
horo
falken@ Could you please review this?
5 years, 8 months ago (2015-04-08 08:09:03 UTC) #3
horo
ping?
5 years, 8 months ago (2015-04-10 03:36:09 UTC) #4
falken
lgtm Very sorry for the delay... I somehow missed the mails. Feel free to ping ...
5 years, 8 months ago (2015-04-15 06:14:24 UTC) #5
falken
Also please add the crbug to the github.
5 years, 8 months ago (2015-04-15 06:14:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067303002/40001
5 years, 8 months ago (2015-04-15 08:30:37 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 10:26:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193776

Powered by Google App Engine
This is Rietveld 408576698