Issue 1067293003: Fix Android build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1067293003: Fix Android build. (Closed)

Created:
5 years, 8 months ago by viettrungluu

Modified:
5 years, 8 months ago

Reviewers:
ojan, eseidel

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix Android build. RenderStyle apparently got smaller. R=ojan@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1dbd032fb60437182a85cec888b7647fa3951dd7

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	sky/engine/core/rendering/style/RenderStyle.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	sky/engine/core/rendering/style/RenderStyle.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

Was broken by 3dee290c0946f1a3a7727e9c08c4c3e2c68d746d, e.g.: http://build.chromium.org/p/client.mojo/builders/Mojo%20Android%20Builder/builds/2080 (TBH, SameSizeAsRenderStyle seems a little shady, and it's not ...

5 years, 8 months ago (2015-04-08 23:26:46 UTC) #1

viettrungluu

5 years, 8 months ago (2015-04-08 23:37:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1dbd032fb60437182a85cec888b7647fa3951dd7 (presubmit successful).

Expand Messages | Collapse Messages