Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1067293003: Fix Android build. (Closed)

Created:
5 years, 8 months ago by viettrungluu
Modified:
5 years, 8 months ago
Reviewers:
ojan, eseidel
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
Was broken by 3dee290c0946f1a3a7727e9c08c4c3e2c68d746d, e.g.: http://build.chromium.org/p/client.mojo/builders/Mojo%20Android%20Builder/builds/2080 (TBH, SameSizeAsRenderStyle seems a little shady, and it's not ...
5 years, 8 months ago (2015-04-08 23:26:46 UTC) #1
ojan
lgtm
5 years, 8 months ago (2015-04-08 23:37:14 UTC) #2
viettrungluu
5 years, 8 months ago (2015-04-08 23:37:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1dbd032fb60437182a85cec888b7647fa3951dd7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698