Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 1067193004: [TurboFan] Fixed handling of CcompareIC return type. (Closed)

Created:
5 years, 8 months ago by Sven Panne
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TurboFan] Fixed handling of CompareIC return type. Although all this code might be moved around later, it's a good idea to unhackify it now. :-) Committed: https://crrev.com/d995d4bd4b3ba8f4ccfae215b1f62272aeaf1458 Cr-Commit-Position: refs/heads/master@{#27672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/compiler/js-generic-lowering.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sven Panne
5 years, 8 months ago (2015-04-08 09:42:16 UTC) #2
Michael Starzinger
LGTM.
5 years, 8 months ago (2015-04-08 12:54:11 UTC) #3
Michael Starzinger
nit about the CL description: s/CallIC/CompareIC/
5 years, 8 months ago (2015-04-08 12:54:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067193004/1
5 years, 8 months ago (2015-04-08 13:35:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 15:57:12 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 15:57:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d995d4bd4b3ba8f4ccfae215b1f62272aeaf1458
Cr-Commit-Position: refs/heads/master@{#27672}

Powered by Google App Engine
This is Rietveld 408576698