Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1067163003: Fixed i-cursor height calculation. (Closed)

Created:
5 years, 8 months ago by Mateusz Szymański
Modified:
5 years ago
Reviewers:
ananta, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed i-cursor height calculation. In previous solution only AND part of cursor mask was taken into account. Now both AND and XOR parts are considered to properly determine bottom point of cursor pointer. BUG=446810 Committed: https://crrev.com/990e693cd5eece2e7a92007281b8e14ce2feec0a Cr-Commit-Position: refs/heads/master@{#364026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M ui/views/corewm/cursor_height_provider_win.cc View 1 chunk +39 lines, -8 lines 0 comments Download

Messages

Total messages: 28 (11 generated)
Mateusz Szymański
5 years, 8 months ago (2015-04-08 07:12:45 UTC) #2
sky
+ananta
5 years, 8 months ago (2015-04-09 15:23:01 UTC) #4
Mateusz Szymański
Any comments/remarks on this review?
5 years, 8 months ago (2015-04-16 07:36:24 UTC) #5
Mateusz Szymański
~ping Any news on this one?
5 years, 5 months ago (2015-07-02 13:02:56 UTC) #6
sky
On 2015/07/02 13:02:56, Mateusz Szymański wrote: > ~ping > > Any news on this one? ...
5 years, 5 months ago (2015-07-20 17:29:25 UTC) #7
Mateusz Szymański
~ping. Please, would someone kindly review this or can we just revert my changes back ...
5 years ago (2015-12-07 08:10:06 UTC) #8
ananta
lgtm
5 years ago (2015-12-08 00:47:46 UTC) #9
sky
I'm assuming Ananta reviewed this, so rubber stamp LGTM
5 years ago (2015-12-08 00:58:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1067163003/1
5 years ago (2015-12-08 08:19:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/154575)
5 years ago (2015-12-08 08:56:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1067163003/1
5 years ago (2015-12-08 09:05:42 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/141414)
5 years ago (2015-12-08 11:17:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1067163003/1
5 years ago (2015-12-08 15:33:09 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/146231) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years ago (2015-12-08 18:10:05 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1067163003/1
5 years ago (2015-12-09 08:49:52 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 09:48:25 UTC) #26
commit-bot: I haz the power
5 years ago (2015-12-09 09:49:38 UTC) #28
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/990e693cd5eece2e7a92007281b8e14ce2feec0a
Cr-Commit-Position: refs/heads/master@{#364026}

Powered by Google App Engine
This is Rietveld 408576698