|
|
Created:
5 years, 8 months ago by Mateusz Szymański Modified:
5 years ago CC:
chromium-reviews, tfarina Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFixed i-cursor height calculation.
In previous solution only AND part of cursor mask
was taken into account. Now both AND and XOR parts
are considered to properly determine bottom point
of cursor pointer.
BUG=446810
Committed: https://crrev.com/990e693cd5eece2e7a92007281b8e14ce2feec0a
Cr-Commit-Position: refs/heads/master@{#364026}
Patch Set 1 #
Messages
Total messages: 28 (11 generated)
mateuszs@opera.com changed reviewers: + sky@chromium.org
sky@chromium.org changed reviewers: + ananta@chromium.org
+ananta
Any comments/remarks on this review?
~ping Any news on this one?
On 2015/07/02 13:02:56, Mateusz Szymański wrote: > ~ping > > Any news on this one? Ananta, the ping is for you.
~ping. Please, would someone kindly review this or can we just revert my changes back to hardcoded "usually good" solution or something? There are two issues hanging on this one that I keep getting notifications about.
lgtm
I'm assuming Ananta reviewed this, so rubber stamp LGTM
The CQ bit was checked by mateuszs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1067163003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
The CQ bit was checked by mateuszs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1067163003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by mateuszs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1067163003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by mateuszs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1067163003/1
Message was sent while issue was closed.
Description was changed from ========== Fixed i-cursor height calculation. In previous solution only AND part of cursor mask was taken into account. Now both AND and XOR parts are considered to properly determine bottom point of cursor pointer. BUG=446810 ========== to ========== Fixed i-cursor height calculation. In previous solution only AND part of cursor mask was taken into account. Now both AND and XOR parts are considered to properly determine bottom point of cursor pointer. BUG=446810 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fixed i-cursor height calculation. In previous solution only AND part of cursor mask was taken into account. Now both AND and XOR parts are considered to properly determine bottom point of cursor pointer. BUG=446810 ========== to ========== Fixed i-cursor height calculation. In previous solution only AND part of cursor mask was taken into account. Now both AND and XOR parts are considered to properly determine bottom point of cursor pointer. BUG=446810 Committed: https://crrev.com/990e693cd5eece2e7a92007281b8e14ce2feec0a Cr-Commit-Position: refs/heads/master@{#364026} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/990e693cd5eece2e7a92007281b8e14ce2feec0a Cr-Commit-Position: refs/heads/master@{#364026} |