Set audible status to false if audio is stopped after prefetch.

media/base/android/media_source_player.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/media_source_player.h"
 
 #include <limits>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
@@ skipping 480 matching lines @@
   if (status == MEDIA_CODEC_OUTPUT_END_OF_STREAM) {
     if (is_audio)
       SetAudible(false);
     return;
   }
 
   if (!playing_) {
     if (is_clock_manager)
       interpolator_.StopInterpolating();
 
     if (is_audio)

[qinmin, 2015/04/14 02:55:10]

how about move this to line 485 ? also, what about calling SetAudible(false) in
Pause(), we don't need very accurate timings on the audio notification.

[timav, 2015/04/28 02:17:55]

I cannot do that because of false starvations which send
PREFETCH_REQUEST_EVENT_PENDING. EVENT_PENDING is immediately creared and we get
flickering. So far I was unable to stop these false starvations.

Calling SetAudible(false) in Pause seems to solve the problem, shall we do that
instead?

       SetAudible(false);
     return;
   }
 
   if (status == MEDIA_CODEC_NO_KEY) {
     if (key_added_while_decode_pending_) {
       DVLOG(2) << __FUNCTION__ << ": Key was added during decoding.";
       ResumePlaybackAfterKeyAdded();
     } else {
       if (is_audio)
@@ skipping 209 matching lines @@
     return;
   }
 
   ClearPendingEvent(PREFETCH_DONE_EVENT_PENDING);
 
   if (pending_event_ != NO_EVENT_PENDING) {
     ProcessPendingEvents();
     return;
   }
 
-  if (!playing_)
+  if (!playing_) {
+    SetAudible(false);
     return;
+  }
 
   start_time_ticks_ = base::TimeTicks::Now();
   start_presentation_timestamp_ = GetCurrentTime();
   if (!interpolator_.interpolating())
     interpolator_.StartInterpolating();
 
   if (!AudioFinished())
     DecodeMoreAudio();
+  else
+    SetAudible(false);
+
 
   if (!VideoFinished())
     DecodeMoreVideo();
 }
 
 void MediaSourcePlayer::OnDemuxerConfigsChanged() {
   manager()->OnMediaMetadataChanged(
       player_id(), duration_, GetVideoWidth(), GetVideoHeight(), true);
 }
 
@@ skipping 82 matching lines @@
   // support setMediaKeys(0) (see http://crbug.com/330324), or when we release
   // MediaDrm when the video is paused, or when the device goes to sleep (see
   // http://crbug.com/272421).
   audio_decoder_job_->SetDrmBridge(NULL);
   video_decoder_job_->SetDrmBridge(NULL);
   cdm_registration_id_ = 0;
   drm_bridge_ = NULL;
 }
 
 }  // namespace media