remoting/webapp/crd/js/desktop_remoting.js - Issue 1067133002: Move ProtocolExtensionManager from SessionConnector into its own class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/desktop_remoting.js

Issue 1067133002: Move ProtocolExtensionManager from SessionConnector into its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and Reviewer's feedback Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/crd/js/desktop_remoting.js

diff --git a/remoting/webapp/crd/js/desktop_remoting.js b/remoting/webapp/crd/js/desktop_remoting.js

index b01ddeb544490851f4e90416d6c854d8957f6960..78ed95fde4bef81941dbcdd8187081a2c71eef13 100644

--- a/remoting/webapp/crd/js/desktop_remoting.js

+++ b/remoting/webapp/crd/js/desktop_remoting.js

@@ -171,7 +171,7 @@ remoting.DesktopRemoting.prototype.onConnected_ = function(connectionInfo) {

if (connectionInfo.session().hasCapability(

remoting.ClientSession.Capability.VIDEO_RECORDER)) {

var recorder = new remoting.VideoFrameRecorder();

- this.sessionConnector_.registerProtocolExtension(recorder);

+ connectionInfo.plugin().extensions().register(recorder);

this.connectedView_.setVideoFrameRecorder(recorder);

}

« no previous file with comments | « remoting/webapp/crd/js/client_session.js ('k') | remoting/webapp/crd/js/me2me_activity.js » ('j') | no next file with comments »