Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: remoting/webapp/crd/js/client_session.js

Issue 1067133002: Move ProtocolExtensionManager from SessionConnector into its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/client_session.js
diff --git a/remoting/webapp/crd/js/client_session.js b/remoting/webapp/crd/js/client_session.js
index 12260801fad8053d2e6fb0a655279b660e8628ca..4fe27a6aedc9d4d051cfd2f41d5de56aed87688b 100644
--- a/remoting/webapp/crd/js/client_session.js
+++ b/remoting/webapp/crd/js/client_session.js
@@ -35,17 +35,13 @@ remoting.ACCESS_TOKEN_RESEND_INTERVAL_MS = 15 * 60 * 1000;
* @param {remoting.ClientPlugin} plugin
* @param {remoting.Host} host The host to connect to.
* @param {remoting.SignalStrategy} signalStrategy Signal strategy.
- * @param {function(string, string):boolean} onExtensionMessage The handler for
- * protocol extension messages. Returns true if a message is recognized;
- * false otherwise.
*
* @constructor
* @extends {base.EventSourceImpl}
* @implements {base.Disposable}
* @implements {remoting.ClientPlugin.ConnectionEventHandler}
*/
-remoting.ClientSession = function(plugin, host, signalStrategy,
- onExtensionMessage) {
+remoting.ClientSession = function(plugin, host, signalStrategy) {
base.inherits(this, base.EventSourceImpl);
/** @private */
@@ -80,9 +76,6 @@ remoting.ClientSession = function(plugin, host, signalStrategy,
*/
this.logHostOfflineErrors_ = true;
- /** @private {function(string, string):boolean} */
- this.onExtensionMessageHandler_ = onExtensionMessage;
-
/** @private {remoting.ClientPlugin} */
this.plugin_ = plugin;
plugin.setConnectionEventHandler(this);
@@ -474,14 +467,6 @@ remoting.ClientSession.prototype.onSetCapabilities = function(capabilities) {
};
/**
- * @param {string} type
- * @param {string} data
- */
-remoting.ClientSession.prototype.onExtensionMessage = function(type, data) {
- this.onExtensionMessageHandler_(type, data);
-};
-
-/**
* @param {remoting.ClientSession.State} newState The new state for the session.
* @return {void} Nothing.
* @private

Powered by Google App Engine
This is Rietveld 408576698